Bug 1447480 - Add a MOZ_ASSERT to make it clear that it can never fall through r?hsivonen draft
authorSylvestre Ledru <sledru@mozilla.com>
Tue, 03 Apr 2018 13:40:59 +0200
changeset 777176 1d13ea7e71536bbd3b08a3839f91026b31976a3f
parent 776621 563a04e747336ddccebcb7f780a913abc739d9b5
child 777767 ee7789ed3bd892e9556763ddf402d86aecbb4bf8
child 778362 138153b71b519f21dfb65e02225ba07c19b0b928
push id105091
push userbmo:sledru@mozilla.com
push dateWed, 04 Apr 2018 10:26:10 +0000
reviewershsivonen
bugs1447480
milestone61.0a1
Bug 1447480 - Add a MOZ_ASSERT to make it clear that it can never fall through r?hsivonen MozReview-Commit-ID: Hq9jG1CVwRK
parser/html/javasrc/TreeBuilder.java
parser/html/nsHtml5TreeBuilder.cpp
--- a/parser/html/javasrc/TreeBuilder.java
+++ b/parser/html/javasrc/TreeBuilder.java
@@ -1162,16 +1162,17 @@ public abstract class TreeBuilder<T> imp
                                     flushCharacters();
                                     reconstructTheActiveFormattingElements();
                                     /*
                                      * Append the token's character to the
                                      * current node.
                                      */
                                     continue;
                             }
+                            // CPPONLY: MOZ_FALLTHROUGH_ASSERT();
                         default:
                             /*
                              * A character token that is not one of one of
                              * U+0009 CHARACTER TABULATION, U+000A LINE FEED
                              * (LF), U+000C FORM FEED (FF), or U+0020 SPACE
                              */
                             switch (mode) {
                                 case INITIAL:
--- a/parser/html/nsHtml5TreeBuilder.cpp
+++ b/parser/html/nsHtml5TreeBuilder.cpp
@@ -394,16 +394,17 @@ nsHtml5TreeBuilder::characters(const cha
                   accumulateCharacters(buf, start, i - start);
                   start = i;
                 }
                 flushCharacters();
                 reconstructTheActiveFormattingElements();
                 continue;
               }
             }
+            MOZ_FALLTHROUGH_ASSERT();
           }
           default: {
             switch (mode) {
               case INITIAL: {
                 documentModeInternal(QUIRKS_MODE, nullptr, nullptr, false);
                 mode = BEFORE_HTML;
                 i--;
                 continue;