Bug 1437895 - Increase *PerfStrip* alert threshold r?wlach draft inc_perfstrip_alert_threshold
authorIonut Goldan <igoldan@mozilla.com>
Fri, 30 Mar 2018 12:22:40 +0300
changeset 775139 c503af663274d8212ceb27dbe780aa7582f66f5b
parent 775138 9b4b4e4924b31d2c408c6e65f30775babd31a99f
push id104627
push userbmo:igoldan@mozilla.com
push dateFri, 30 Mar 2018 09:23:22 +0000
reviewerswlach
bugs1437895
milestone61.0a1
Bug 1437895 - Increase *PerfStrip* alert threshold r?wlach MozReview-Commit-ID: 4MoKkCif67s
testing/gtest/mozilla/MozGTestBench.cpp
--- a/testing/gtest/mozilla/MozGTestBench.cpp
+++ b/testing/gtest/mozilla/MozGTestBench.cpp
@@ -40,21 +40,27 @@ void GTestBench(const char* aSuite, cons
   }
   replicatesStr += "]";
 
   // median is at index floor(i/2) if number of replicates is odd,
   // (i/2-1) if even
   std::sort(durations.begin(), durations.end());
   int medianIndex = (MOZ_GTEST_NUM_ITERATIONS / 2) + ((durations.size() % 2 == 0) ? (-1) : 0);
 
-  // Print the result for each test. Let perfherder aggregate for us
-  printf("PERFHERDER_DATA: {\"framework\": {\"name\": \"%s\"}, "
+  std::string perfherder_data_dump = "PERFHERDER_DATA: {\"framework\": {\"name\": \"%s\"}, "
          "\"suites\": [{\"name\": \"%s\", \"subtests\": "
          "[{\"name\": \"%s\", \"value\": %i, \"replicates\": %s, "
-         "\"lowerIsBetter\": true, \"shouldAlert\": %s}]"
-         "}]}\n",
+         "\"lowerIsBetter\": true, \"shouldAlert\": %s";
+
+  if (strstr(aName, "PerfStrip")) {
+    perfherder_data_dump += ", \"alertThreshold\": 8";
+  }
+
+  perfherder_data_dump += "}]}]}\n";
+
+  // Print the result for each test. Let perfherder aggregate for us
+  printf(perfherder_data_dump.c_str(),
          MOZ_GTEST_BENCH_FRAMEWORK, aSuite, aName, durations[medianIndex],
          replicatesStr.c_str(), shouldAlert ? "true" : "false");
 #endif
 }
 
 } // mozilla
-