Bug 1448807 - Remove showWindowResizer from browser binding. r=enndeakin draft
authorTim Nguyen <ntim.bugs@gmail.com>
Mon, 26 Mar 2018 16:41:11 +0200
changeset 772588 c8003a4ef67d81972a4a400e0fa473571eeeefd7
parent 772587 dd2d726b75ab4d34b678dbfadb7b1386c46f2c52
push id103969
push userbmo:ntim.bugs@gmail.com
push dateMon, 26 Mar 2018 14:41:56 +0000
reviewersenndeakin
bugs1448807
milestone61.0a1
Bug 1448807 - Remove showWindowResizer from browser binding. r=enndeakin MozReview-Commit-ID: KQ8qtmdMkBn
layout/generic/nsGfxScrollFrame.cpp
layout/generic/nsSubDocumentFrame.cpp
toolkit/content/widgets/browser.xml
xpcom/ds/nsGkAtomList.h
--- a/layout/generic/nsGfxScrollFrame.cpp
+++ b/layout/generic/nsGfxScrollFrame.cpp
@@ -1027,27 +1027,16 @@ nsHTMLScrollFrame::Reflow(nsPresContext*
     reflowHScrollbar = NEEDS_REFLOW(mHelper.mHScrollbarBox);
     reflowVScrollbar = NEEDS_REFLOW(mHelper.mVScrollbarBox);
     reflowScrollCorner = NEEDS_REFLOW(mHelper.mScrollCornerBox) ||
                          NEEDS_REFLOW(mHelper.mResizerBox);
 
     #undef NEEDS_REFLOW
   }
 
-  if (mHelper.mIsRoot) {
-    mHelper.mCollapsedResizer = true;
-
-    Element* browserRoot = GetBrowserRoot(mContent);
-    if (browserRoot) {
-      bool showResizer = browserRoot->HasAttr(kNameSpaceID_None, nsGkAtoms::showresizer);
-      reflowScrollCorner = showResizer == mHelper.mCollapsedResizer;
-      mHelper.mCollapsedResizer = !showResizer;
-    }
-  }
-
   nsRect oldScrollAreaBounds = mHelper.mScrollPort;
   nsRect oldScrolledAreaBounds =
     mHelper.mScrolledFrame->GetScrollableOverflowRectRelativeToParent();
   nsPoint oldScrollPosition = mHelper.GetScrollPosition();
 
   state.mComputedBorder = aReflowInput.ComputedPhysicalBorderPadding() -
     aReflowInput.ComputedPhysicalPadding();
 
--- a/layout/generic/nsSubDocumentFrame.cpp
+++ b/layout/generic/nsSubDocumentFrame.cpp
@@ -900,23 +900,16 @@ nsSubDocumentFrame::AttributeChanged(int
         // concrete class, yay!
         nsHTMLFramesetFrame* framesetFrame = do_QueryFrame(parentFrame);
         if (framesetFrame) {
           framesetFrame->RecalculateBorderResize();
         }
       }
     }
   }
-  else if (aAttribute == nsGkAtoms::showresizer) {
-    nsIFrame* rootFrame = GetSubdocumentRootFrame();
-    if (rootFrame) {
-      rootFrame->PresShell()->
-        FrameNeedsReflow(rootFrame, nsIPresShell::eResize, NS_FRAME_IS_DIRTY);
-    }
-  }
   else if (aAttribute == nsGkAtoms::marginwidth ||
            aAttribute == nsGkAtoms::marginheight) {
 
     // Retrieve the attributes
     CSSIntSize margins = GetMarginAttributes();
 
     // Notify the frameloader
     RefPtr<nsFrameLoader> frameloader = FrameLoader();
--- a/toolkit/content/widgets/browser.xml
+++ b/toolkit/content/widgets/browser.xml
@@ -477,22 +477,16 @@
             return this.contentDocument.documentLoadGroup
                        .requestContextID;
           } catch (e) {
             return null;
           }
         ]]></getter>
       </property>
 
-      <property name="showWindowResizer"
-                onset="if (val) this.setAttribute('showresizer', 'true');
-                       else this.removeAttribute('showresizer');
-                       return val;"
-                onget="return this.getAttribute('showresizer') == 'true';"/>
-
       <property name="fullZoom">
         <getter><![CDATA[
           return this.markupDocumentViewer.fullZoom;
         ]]></getter>
         <setter><![CDATA[
           this.markupDocumentViewer.fullZoom = val;
         ]]></setter>
       </property>
--- a/xpcom/ds/nsGkAtomList.h
+++ b/xpcom/ds/nsGkAtomList.h
@@ -1242,17 +1242,16 @@ GK_ATOM(selectedIndex, "selectedIndex")
 GK_ATOM(selectedindex, "selectedindex")
 GK_ATOM(self, "self")
 GK_ATOM(seltype, "seltype")
 GK_ATOM(setcookie, "set-cookie")
 GK_ATOM(setter, "setter")
 GK_ATOM(shape, "shape")
 GK_ATOM(show, "show")
 GK_ATOM(showcaret, "showcaret")
-GK_ATOM(showresizer, "showresizer")
 GK_ATOM(simple, "simple")
 GK_ATOM(simp_chinese_formal, "simp-chinese-formal")
 GK_ATOM(simp_chinese_informal, "simp-chinese-informal")
 GK_ATOM(single, "single")
 GK_ATOM(size, "size")
 GK_ATOM(sizes, "sizes")
 GK_ATOM(sizemode, "sizemode")
 GK_ATOM(sizetopopup, "sizetopopup")