Bug 1447982 - Remove early exit when no change on Reconfigure. r?padenot draft
authorAndreas Pehrson <pehrsons@mozilla.com>
Mon, 26 Mar 2018 12:23:12 +0200
changeset 781071 d515517731a94cc7dfc42d5855d19df132f61a62
parent 781070 28e8885e97ff560b926f17cf754371880d47b954
child 781072 8398b602bb1a0e95f9ba39fde591deb18249811d
push id106197
push userbmo:apehrson@mozilla.com
push dateThu, 12 Apr 2018 13:32:52 +0000
reviewerspadenot
bugs1447982
milestone61.0a1
Bug 1447982 - Remove early exit when no change on Reconfigure. r?padenot We don't want to skip all remaining steps. For now it just affects some logging, but there may be new ones added in the future. MozReview-Commit-ID: 7fBdgLNT780
dom/media/webrtc/MediaEngineWebRTCAudio.cpp
--- a/dom/media/webrtc/MediaEngineWebRTCAudio.cpp
+++ b/dom/media/webrtc/MediaEngineWebRTCAudio.cpp
@@ -466,20 +466,16 @@ MediaEngineWebRTCMicrophoneSource::Updat
         mAudioInput->GetChannelCount(channelCount);
         MOZ_ASSERT(channelCount > 0);
         prefs.mChannels = channelCount;
       }
       break;
 
     case kStarted:
     case kStopped:
-      if (prefs == mLastPrefs) {
-        return NS_OK;
-      }
-
       if (prefs.mChannels != mLastPrefs.mChannels) {
         // If the channel count changed, tell the MSG to open a new driver with
         // the correct channel count.
         MOZ_ASSERT(!mAllocations.IsEmpty());
         RefPtr<SourceMediaStream> stream;
         for (const Allocation& allocation : mAllocations) {
           if (allocation.mStream && allocation.mStream->GraphImpl()) {
             stream = allocation.mStream;