Bug 1448576 - Use AssignLiteral for short ASCII literal AudioChannelService. r?baku. draft
authorHenri Sivonen <hsivonen@hsivonen.fi>
Sat, 24 Mar 2018 20:11:14 +0200
changeset 772013 3b59d327ed6d9bf5b669769f2e20a5d61fadfd0e
parent 772012 aa0c67878b479f7a96279b1699f02f5908aa3275
child 772014 30e9c39bf5c10988fd421adf34a5415bc144b964
push id103833
push userbmo:hsivonen@hsivonen.fi
push dateSat, 24 Mar 2018 18:11:40 +0000
reviewersbaku
bugs1448576
milestone61.0a1
Bug 1448576 - Use AssignLiteral for short ASCII literal AudioChannelService. r?baku. MozReview-Commit-ID: 3pXhsf9Q32Q
dom/audiochannel/AudioChannelService.cpp
--- a/dom/audiochannel/AudioChannelService.cpp
+++ b/dom/audiochannel/AudioChannelService.cpp
@@ -108,25 +108,25 @@ public:
     MOZ_LOG(AudioChannelService::GetAudioChannelLog(), LogLevel::Debug,
            ("AudioPlaybackRunnable, active = %s, reason = %s\n",
             mActive ? "true" : "false", AudibleChangedReasonToStr(mReason)));
 
     return NS_OK;
   }
 
 private:
-  void GetActiveState(nsAString& astate)
+  void GetActiveState(nsAString& aState)
   {
     if (mActive) {
-      CopyASCIItoUTF16("active", astate);
+      aState.AssignLiteral("active");
     } else {
       if(mReason == AudioChannelService::AudibleChangedReasons::ePauseStateChanged) {
-        CopyASCIItoUTF16("inactive-pause", astate);
+        aState.AssignLiteral("inactive-pause");
       } else {
-        CopyASCIItoUTF16("inactive-nonaudible", astate);
+        aState.AssignLiteral("inactive-nonaudible");
       }
     }
   }
 
   nsCOMPtr<nsPIDOMWindowOuter> mWindow;
   bool mActive;
   AudioChannelService::AudibleChangedReasons mReason;
 };