Bug 1414084 - Part 14 - Rename isPwaAdded for more clarity. r?grisha
Despite its name and the original purpose for which it was added, that function
generically checks for duplicates among all PageActions, not just the PWA badge.
MozReview-Commit-ID: Ae6FsLb9F3S
--- a/mobile/android/base/java/org/mozilla/gecko/toolbar/PageActionLayout.java
+++ b/mobile/android/base/java/org/mozilla/gecko/toolbar/PageActionLayout.java
@@ -144,18 +144,17 @@ public class PageActionLayout extends Th
private void onAddPageAction(final GeckoBundle message) {
ThreadUtils.assertOnUiThread();
hidePreviousConfirmPrompt();
final String id = message.getString("id");
- boolean alreadyAdded = isPwaAdded(id);
- if (alreadyAdded) {
+ if (isPageActionAlreadyAdded(id)) {
return;
}
maybeShowPwaOnboarding(id);
final String title = message.getString("title");
final String imageURL = message.getString("icon");
final boolean important = message.getBoolean("important");
@@ -201,17 +200,17 @@ public class PageActionLayout extends Th
final boolean show = prefs.getBoolean(PREF_PWA_ONBOARDING, true);
if (show && ShortcutUtils.isPinShortcutSupported()) {
PwaOnboarding.show(getContext());
prefs.edit().putBoolean(PREF_PWA_ONBOARDING, false).apply();
}
}
}
- private boolean isPwaAdded(String id) {
+ private boolean isPageActionAlreadyAdded(String id) {
for (PageAction pageAction : mPageActionList) {
if (pageAction.getID() != null && pageAction.getID().equals(id)) {
return true;
}
}
return false;
}