Bug 1411685: Remove another accessibility related diagnostic crash on Nightly. r=aklotz draft
authorJames Teh <jteh@mozilla.com>
Fri, 23 Mar 2018 15:21:56 -0400
changeset 771724 316a30137e115eb941e29a2ef9aa60c423eb5a9a
parent 771610 5bc910c1f477d8095dcde2c96b7e8639211b9a84
push id103764
push userbmo:jteh@mozilla.com
push dateFri, 23 Mar 2018 19:24:10 +0000
reviewersaklotz
bugs1411685, 1431404
milestone61.0a1
Bug 1411685: Remove another accessibility related diagnostic crash on Nightly. r=aklotz I missed this one in bug 1431404. This condition is rare and does indicate a problem which breaks accessibility. However, we aren't getting any closer to diagnosing this as a result of this crash, so it causes user pain without any gain to us. MozReview-Commit-ID: GncQGeZckrV
ipc/mscom/ProxyStream.cpp
--- a/ipc/mscom/ProxyStream.cpp
+++ b/ipc/mscom/ProxyStream.cpp
@@ -326,19 +326,17 @@ ProxyStream::ProxyStream(REFIID aIID, IU
     }
 
 #if defined(ACCESSIBILITY)
     ActivationContext::GetCurrentManifestPath(manifestPath);
 #endif // defined(ACCESSIBILITY)
 
     marshalResult = ::CoMarshalInterface(stream, aIID, aObject, MSHCTX_LOCAL,
                                          nullptr, mshlFlags);
-#if !defined(MOZ_DEV_EDITION)
-    MOZ_DIAGNOSTIC_ASSERT(marshalResult != E_INVALIDARG);
-#endif // !defined(MOZ_DEV_EDITION)
+    MOZ_ASSERT(marshalResult != E_INVALIDARG);
     if (FAILED(marshalResult)) {
       return;
     }
 
     STATSTG statstg;
     statResult = stream->Stat(&statstg, STATFLAG_NONAME);
     if (SUCCEEDED(statResult)) {
       streamSize = static_cast<int>(statstg.cbSize.LowPart);