Bug 972324 : Test for changes of the revision value in payloads , r?chutten draft
authorakriti <akriti.v10@gmail.com>
Fri, 23 Mar 2018 22:29:44 +0530
changeset 771663 6ccea34a81b309aa41e8c3a918f37f517de03cc0
parent 765972 8863806b9e28e9a5267c34c2e000f3cc0265f944
push id103746
push userbmo:akriti.v10@gmail.com
push dateFri, 23 Mar 2018 17:02:14 +0000
reviewerschutten
bugs972324
milestone60.0a1
Bug 972324 : Test for changes of the revision value in payloads , r?chutten MozReview-Commit-ID: HaANh3cySNK
toolkit/components/telemetry/tests/unit/test_TelemetrySession.js
--- a/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js
+++ b/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js
@@ -198,16 +198,22 @@ function checkPayloadInfo(data) {
   for (let f in EXPECTED_INFO_FIELDS_TYPES) {
     Assert.ok(f in data, f + " must be available.");
 
     let checkFunc = EXPECTED_INFO_FIELDS_TYPES[f];
     Assert.ok(checkFunc(data[f]),
               f + " must have the correct type and valid data " + data[f]);
   }
 
+  // Check for a valid revision.
+  if (data.revision != "") {
+    const revisionUrlRegEx = /^http[s]?:\/\/hg.mozilla.org(\/[a-z\S]+)+(\/rev\/[0-9a-z]+)$/g;
+    Assert.ok(revisionUrlRegEx.test(data.revision));
+  }
+
   // Previous buildId is not mandatory.
   if (data.previousBuildId) {
     Assert.ok(stringCheck(data.previousBuildId));
   }
 
   Assert.ok(ALLOWED_REASONS.find(r => r == data.reason),
             "Payload must contain an allowed reason.");