Bug 1447056 part 1 - Move eWindowType_sheet to be before eWindowType_popup. r?mstange draft
authorXidorn Quan <me@upsuper.org>
Fri, 23 Mar 2018 21:07:06 +1100
changeset 771963 1d1f62a81d9fc059af9038eebc64256aeba397d3
parent 771944 d7b0d0e7228da9d690df6f105b865db973789c34
child 771964 1c6a0b0aae636f658555d4e2261eb3731df71f65
push id103809
push userxquan@mozilla.com
push dateSat, 24 Mar 2018 01:18:18 +0000
reviewersmstange
bugs1447056
milestone61.0a1
Bug 1447056 part 1 - Move eWindowType_sheet to be before eWindowType_popup. r?mstange nsBaseWidget::BoundsUseDesktopPixels() states that window types before eWindowType_popup take desktop pixels rather than device pixels for parameters of Move and Resize. Cocoa widget seems to treat all of them as desktop pixels, and sheet is one of the window types that it can actually open, so it should be put before popup so that BoundsUseDesktopPixels() is correct on that. MozReview-Commit-ID: FPqOoUQlQCy
widget/nsWidgetInitData.h
--- a/widget/nsWidgetInitData.h
+++ b/widget/nsWidgetInitData.h
@@ -11,24 +11,24 @@
  *
  * Don't alter previously encoded enum values - 3rd party apps may look at
  * these.
  */
 enum nsWindowType {
   eWindowType_toplevel,           // default top level window
   eWindowType_dialog,             // top level window but usually handled differently
                                   // by the OS
+  eWindowType_sheet,              // MacOSX sheet (special dialog class)
   eWindowType_popup,              // used for combo boxes, etc
   eWindowType_child,              // child windows (contained inside a window on the
                                   // desktop (has no border))
   eWindowType_invisible,          // windows that are invisible or offscreen
   eWindowType_plugin,             // plugin window
   eWindowType_plugin_ipc_chrome,  // chrome side native widget for plugins (e10s)
   eWindowType_plugin_ipc_content, // content side puppet widget for plugins (e10s)
-  eWindowType_sheet,              // MacOSX sheet (special dialog class)
 };
 
 /**
  * Popup types
  *
  * For eWindowType_popup
  */
 enum nsPopupType {