Bug 1431256 correction: AccessibleHandler: Really return E_NOINTERFACE for IEnumVARIANT if there are no children. r?MarcoZ draft
authorJames Teh <jteh@mozilla.com>
Thu, 22 Mar 2018 17:57:34 -0400
changeset 771306 16dfe43f1ab0eda53aee111827f1a06bb929a0b1
parent 770836 d7c9299d75db2a5929c5172fb3c36ba5ed1f59a3
push id103655
push userbmo:jteh@mozilla.com
push dateThu, 22 Mar 2018 22:00:42 +0000
reviewersMarcoZ
bugs1431256
milestone61.0a1
Bug 1431256 correction: AccessibleHandler: Really return E_NOINTERFACE for IEnumVARIANT if there are no children. r?MarcoZ A typo meant we were checking the address of mChildCount, not the value. MozReview-Commit-ID: 7Hit3FBy9pr
accessible/ipc/win/handler/AccessibleHandler.cpp
--- a/accessible/ipc/win/handler/AccessibleHandler.cpp
+++ b/accessible/ipc/win/handler/AccessibleHandler.cpp
@@ -401,17 +401,17 @@ AccessibleHandler::QueryHandlerInterface
 
   if (aIid == IID_IProvideClassInfo) {
     RefPtr<IProvideClassInfo> clsInfo(this);
     clsInfo.forget(aOutInterface);
     return S_OK;
   }
 
   if (aIid == IID_IEnumVARIANT && mCachedData.mGeckoBackChannel) {
-    if (&mCachedData.mDynamicData.mChildCount == 0) {
+    if (mCachedData.mDynamicData.mChildCount == 0) {
       return E_NOINTERFACE;
     }
     RefPtr<IEnumVARIANT> childEnum(
       new HandlerChildEnumerator(this, mCachedData.mGeckoBackChannel));
     childEnum.forget(aOutInterface);
     return S_OK;
   }