Fixed eslint reports - Bug 1417810 r?ntim draft
authorSatish <psatish@live.in>
Wed, 21 Mar 2018 15:22:36 +0530
changeset 770427 4f688f96b1976ddfdd88532d2ed84f24534f8eb5
parent 770421 e0db90b8884960756d92e2f61bd0839cdee1eb8e
push id103412
push userbmo:psatish@live.in
push dateWed, 21 Mar 2018 09:53:19 +0000
reviewersntim
bugs1417810
milestone61.0a1
Fixed eslint reports - Bug 1417810 r?ntim MozReview-Commit-ID: CYp1hL793sE
toolkit/components/extensions/ext-browserSettings.js
--- a/toolkit/components/extensions/ext-browserSettings.js
+++ b/toolkit/components/extensions/ext-browserSettings.js
@@ -373,29 +373,34 @@ this.browserSettings = class extends Ext
                 "permissions.default.desktop-notification", null);
             return prefValue === PERM_DENY_ACTION;
           }),
         useDocumentColors: Object.assign(
           getSettingsAPI(
             extension, "useDocumentColors",
             () => {
               let prefValue = Services.prefs.getIntPref("browser.display.document_color_use");
-              return prefValue === 1 ? "never" : (prefValue === 2 ? "always" : "high-contrast-only");
+              if (prefValue === 1) {
+                return "never";
+              } else if (prefValue === 2) {
+                return "always";
+              }
+              return "high-contrast-only";
             }
           ),
           {
             set: details => {
               if (!["never", "always", "high-contrast-only"].includes(details.value)) {
                 throw new ExtensionError(
                   `${details.value} is not a valid value for useDocumentColors.`);
               }
               let prefValue = 0; // initialize to 0 - auto/high-contrast-only
-              if ("never" === details.value) {
+              if (details.value === "never") {
                 prefValue = 1;
-              } else if ("always" === details.value) {
+              } else if (details.value === "always") {
                 prefValue = 2;
               }
               return ExtensionPreferencesManager.setSetting(
                 extension.id, "useDocumentColors", prefValue);
             },
           }
         ),
       },