Bug 1447045 - Increase maximize delta to 22 px. r?maja_zf draft
authorAndreas Tolfsen <ato@sny.no>
Mon, 19 Mar 2018 16:35:26 +0000
changeset 769457 884a77955eb9ec8b7d7b268bf28e1644d8cd45de
parent 769320 4f1014eb5039bdfdd7a39fb7785d102df1994a6f
push id103130
push userbmo:ato@sny.no
push dateMon, 19 Mar 2018 16:38:34 +0000
reviewersmaja_zf
bugs1447045
milestone61.0a1
Bug 1447045 - Increase maximize delta to 22 px. r?maja_zf Linux window managers and desktop environments can cause the available surface area of the screen to be shrunk due to UI elements such as menus. Window managers can also add additional window decorations that are outside the control of Firefox. When X11 forwarding a Firefox window to macOS the XQuartz window decoration adds 22 px. This patch increases the delta from 8 px. MozReview-Commit-ID: 8I6G6cZvAmD
testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py
--- a/testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py
+++ b/testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py
@@ -29,17 +29,17 @@ class TestWindowMaximize(MarionetteTestC
     def tearDown(self):
         self.marionette.set_window_size(
             self.original_size["width"], self.original_size["height"])
 
     def assert_window_maximized(self, actual, delta=None):
         if self.marionette.session_capabilities["platformName"] == "windows_nt":
             delta = 16
         else:
-            delta = 8
+            delta = 22
 
         self.assertGreaterEqual(
             actual["width"], self.max["width"] - delta,
             msg="Window width is not within {delta} px of availWidth: "
                 "current width {current} should be greater than or equal to max width {max}"
                 .format(delta=delta, current=actual["width"], max=self.max["width"] - delta))
         self.assertGreaterEqual(
             actual["height"], self.max["height"] - delta,