Bug 1446471 - Remove unused --stop argument from `mach python-test`; r?build draft
authorGregory Szorc <gps@mozilla.com>
Tue, 06 Mar 2018 19:04:04 -0800
changeset 768668 fe66db548c8fe571c7af18c83b3973baf586e6ef
parent 768667 db24d7450802a55d7ce84679654a8f3f93d2d674
child 768669 e9716d951375710a4ca71e0b52281f0afd3d3268
push id102952
push userbmo:gps@mozilla.com
push dateFri, 16 Mar 2018 17:15:15 +0000
reviewersbuild
bugs1446471
milestone61.0a1
Bug 1446471 - Remove unused --stop argument from `mach python-test`; r?build This argument does nothing. While that's arguably a bug, I have no desire to fix it. So remove dead code. MozReview-Commit-ID: 9tToF66I7HE
python/mach_commands.py
--- a/python/mach_commands.py
+++ b/python/mach_commands.py
@@ -61,20 +61,16 @@ class MachCommands(MachCommandBase):
                                 append_env=append_env)
 
     @Command('python-test', category='testing',
              description='Run Python unit tests with an appropriate test runner.')
     @CommandArgument('-v', '--verbose',
                      default=False,
                      action='store_true',
                      help='Verbose output.')
-    @CommandArgument('--stop',
-                     default=False,
-                     action='store_true',
-                     help='Stop running tests after the first error or failure.')
     @CommandArgument('-j', '--jobs',
                      default=1,
                      type=int,
                      help='Number of concurrent jobs to run. Default is 1.')
     @CommandArgument('--subsuite',
                      default=None,
                      help=('Python subsuite to run. If not specified, all subsuites are run. '
                            'Use the string `default` to only run tests without a subsuite.'))
@@ -90,17 +86,16 @@ class MachCommands(MachCommandBase):
             import mozfile
             mozfile.remove(tempdir)
 
     def run_python_tests(self,
                          tests=[],
                          test_objects=None,
                          subsuite=None,
                          verbose=False,
-                         stop=False,
                          jobs=1,
                          **kwargs):
         self._activate_virtualenv()
 
         # Python's unittest, and in particular discover, has problems with
         # clashing namespaces when importing multiple test modules. What follows
         # is a simple way to keep environments separate, at the price of
         # launching Python multiple times. Most tests are run via mozunit,