Bug 1446270 - Android/arm target should turn on crash reporter as default. r?Build draft
authorMakoto Kato <m_kato@ga2.so-net.ne.jp>
Fri, 16 Mar 2018 16:38:14 +0900
changeset 768355 681ce5aec37fb521f03b44bf29ec2401b0ba804b
parent 768313 16e69d4df5dcef04f1d3f4b6fcf9284d321bce6f
push id102865
push userbmo:m_kato@ga2.so-net.ne.jp
push dateFri, 16 Mar 2018 07:42:58 +0000
reviewersBuild
bugs1446270
milestone61.0a1
Bug 1446270 - Android/arm target should turn on crash reporter as default. r?Build target value of Anndroid/arm is arm-unknown-linux-androideabi, so arm-*-linux* matches on android/arm and MOZ_CRASHREPORTER is unset as default option. Since taskcluster's build adds --enable-crashrepoter as default, we should set it as developer's default too. MozReview-Commit-ID: 8V6sWAN07F9
old-configure.in
--- a/old-configure.in
+++ b/old-configure.in
@@ -2826,24 +2826,24 @@ case $target in
 i?86-*-mingw*|x86_64-*-mingw*)
   MOZ_CRASHREPORTER=1
   ;;
 i?86-apple-darwin*|x86_64-apple-darwin*)
   if test -z "$MOZ_IOS"; then
     MOZ_CRASHREPORTER=1
   fi
   ;;
+*-android*|*-linuxandroid*)
+  MOZ_CRASHREPORTER=1
+  ;;
 i?86-*-linux*|x86_64-*-linux*|arm-*-linux*)
   if test "$MOZ_ENABLE_GTK"; then
     MOZ_CRASHREPORTER=1
   fi
   ;;
-*-android*|*-linuxandroid*)
-  MOZ_CRASHREPORTER=1
-  ;;
 esac
 
 MOZ_ARG_DISABLE_BOOL(crashreporter,
 [  --disable-crashreporter Disable breakpad crash reporting],
     [MOZ_CRASHREPORTER=],
     [MOZ_CRASHREPORTER=F # Force enable breakpad])
 
 if test "$OS_ARCH" != "$HOST_OS_ARCH" -a "$OS_ARCH" != "WINNT" -a "$OS_ARCH" != "Darwin"; then