Bug 1445509 - Correctly compare height in open-features-non-integer-height.html test. r?bz draft
authorXidorn Quan <me@upsuper.org>
Wed, 14 Mar 2018 11:08:09 +1100
changeset 767172 bf39f8df42194c4877ff32e533a206b943836762
parent 767171 2fa3bd253d84e075336511f7d3047bbc5b4f0922
child 767177 2cd5bbb1de7c649ce06e7795d8fbf3d3780e9370
push id102525
push userxquan@mozilla.com
push dateWed, 14 Mar 2018 00:10:20 +0000
reviewersbz
bugs1445509
milestone61.0a1
Bug 1445509 - Correctly compare height in open-features-non-integer-height.html test. r?bz MozReview-Commit-ID: A99KG22to7w
testing/web-platform/meta/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html.ini
testing/web-platform/tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html
deleted file mode 100644
--- a/testing/web-platform/meta/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html.ini
+++ /dev/null
@@ -1,4 +0,0 @@
-[open-features-non-integer-height.html]
-  [top=0,left=0: absence of feature "height" should be treated same as "height=0"]
-    expected: FAIL
-
--- a/testing/web-platform/tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html
+++ b/testing/web-platform/tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html
@@ -35,17 +35,17 @@ function runWindowTests (baselineDimensi
   // as that feature set to 0
   [ featuresPrefix,
     'top=0,left=0',
   ].forEach(feature => {
     async_test(t => {
       var prefixedMessage = new PrefixedMessageTest();
       prefixedMessage.onMessage(t.step_func_done((data, e) => {
         e.source.close();
-        assert_equals(data.width, baselineDimensions.width);
+        assert_equals(data.height, baselineDimensions.height);
       }));
       var win = window.open(prefixedMessage.url(windowURL), '', feature);
     }, `${feature}: absence of feature "height" should be treated same as "height=0"`);
   });
 
   // When code point in first position is not an ASCII digit, "+" or "-",
   // that's an error and the value becomes 0
   [ 'height=/404',