Bug 1444219 - Remove unnecessary call to MozbuildObject.from_environment r?build-peer draft
authorGeoff Lankow <geoff@darktrojan.net>
Sun, 11 Mar 2018 21:55:45 +1300
changeset 765943 60c8ca3d14c0ae62babef41d19a73692b7af3342
parent 762291 5410375734d6ca8be3ff06acdc1c951d87d644ee
push id102185
push userbmo:geoff@darktrojan.net
push dateSun, 11 Mar 2018 08:57:17 +0000
reviewersbuild-peer
bugs1444219
milestone60.0a1
Bug 1444219 - Remove unnecessary call to MozbuildObject.from_environment r?build-peer MozReview-Commit-ID: 4KP2H9HVQbG
python/mozbuild/mozbuild/mach_commands.py
--- a/python/mozbuild/mozbuild/mach_commands.py
+++ b/python/mozbuild/mozbuild/mach_commands.py
@@ -1142,26 +1142,23 @@ class PackageFrontend(MachCommandBase):
 
         '''
         pass
 
     def _make_artifacts(self, tree=None, job=None, skip_cache=False):
         state_dir = self._mach_context.state_dir
         cache_dir = os.path.join(state_dir, 'package-frontend')
 
-        here = os.path.abspath(os.path.dirname(__file__))
-        build_obj = MozbuildObject.from_environment(cwd=here)
-
         hg = None
-        if conditions.is_hg(build_obj):
-            hg = build_obj.substs['HG']
+        if conditions.is_hg(self):
+            hg = self.substs['HG']
 
         git = None
-        if conditions.is_git(build_obj):
-            git = build_obj.substs['GIT']
+        if conditions.is_git(self):
+            git = self.substs['GIT']
 
         from mozbuild.artifacts import Artifacts
         artifacts = Artifacts(tree, self.substs, self.defines, job,
                               log=self.log, cache_dir=cache_dir,
                               skip_cache=skip_cache, hg=hg, git=git,
                               topsrcdir=self.topsrcdir)
         return artifacts