Bug 1443632 - Change screenshots tour action button back to an <a>. r=kitcambridge draft
authorMatthew Noorenberghe <mozilla@noorenberghe.ca>
Fri, 09 Mar 2018 17:58:18 -0800
changeset 765717 fb3fefac449644b8b83286c92d13ebd677a41055
parent 765587 2c914b6e666887816da2ea14448aa055f24b19dd
push id102150
push usermozilla@noorenberghe.ca
push dateSat, 10 Mar 2018 01:58:58 +0000
reviewerskitcambridge
bugs1443632
milestone60.0a1
Bug 1443632 - Change screenshots tour action button back to an <a>. r=kitcambridge MozReview-Commit-ID: DeEWxnurLty
browser/extensions/onboarding/content/onboarding.js
--- a/browser/extensions/onboarding/content/onboarding.js
+++ b/browser/extensions/onboarding/content/onboarding.js
@@ -62,22 +62,22 @@ function createOnboardingTourContent(div
 
   div.appendChild(section);
   return section;
 }
 
 /**
  * Helper function to create the tour button UI element.
  */
-function createOnboardingTourButton(div, buttonId, l10nId) {
+function createOnboardingTourButton(div, buttonId, l10nId, buttonElementTagName = "button") {
   let doc = div.ownerDocument;
   let aside = doc.createElement("aside");
   aside.className = "onboarding-tour-button-container";
 
-  let button = doc.createElement("button");
+  let button = doc.createElement(buttonElementTagName);
   button.id = buttonId;
   button.className = "onboarding-tour-action-button";
   button.setAttribute("data-l10n-id", l10nId);
   aside.appendChild(button);
 
   div.appendChild(aside);
   return aside;
 }
@@ -398,19 +398,21 @@ var onboardingTourset = {
       // Screenshot tour opens the screenshot page directly, see below a#onboarding-tour-screenshots-button.
       // The screenshots page should be responsible for highlighting the Screenshots button
 
       createOnboardingTourDescription(div,
         "onboarding.tour-screenshots.title", "onboarding.tour-screenshots.description");
       createOnboardingTourContent(div, "resource://onboarding/img/figure_screenshots.svg");
 
       let aside = createOnboardingTourButton(div,
-        "onboarding-tour-screenshots-button", "onboarding.tour-screenshots.button");
+                                             "onboarding-tour-screenshots-button",
+                                             "onboarding.tour-screenshots.button",
+                                             "a");
 
-      let button = aside.querySelector("button");
+      let button = aside.querySelector("a");
       button.setAttribute("href", "https://screenshots.firefox.com/#tour");
       button.setAttribute("target", "_blank");
 
       return div;
     },
   },
 };