Bug 1444481 part 1: Add some needed #includes to ComputedTimingFunction.h and FrameMetrics.h. r?xidorn draft
authorDaniel Holbert <dholbert@cs.stanford.edu>
Fri, 09 Mar 2018 11:52:02 -0800
changeset 765449 5db5f209e81591d7d5922d6323c087bd4e11a35e
parent 765405 90c70e5122f6da891b59c579a3c7d0c02a6610d4
child 765450 b648d9cf1ee20cb1ead684aaa7b8f06c5ebc6ec4
child 765452 d9f1ca240dc8b95c26c3d560bc64041829da53ec
push id102075
push userdholbert@mozilla.com
push dateFri, 09 Mar 2018 19:52:13 +0000
reviewersxidorn
bugs1444481
milestone60.0a1
Bug 1444481 part 1: Add some needed #includes to ComputedTimingFunction.h and FrameMetrics.h. r?xidorn (This is a helper patch -- I'm splitting this into its own patch since it's changing files in other directories, and also so that the main patches here can be a bit more direct.) Without this change, the other patches in this series would cause compile failures in the headers that I'm fixing up here (because the other patches will be removing #includes from some headers that these files were inadvertently depending on). As of this patch, ComputedTimingFunction.h will now be including: - nsDebug.h to provide NS_ASSERTION - nsStringFwd.h to provide a forward-declaration for "nsAString&" - Assertions.h to provide MOZ_ASSERT - Maybe.h to provide Maybe<ComputedTimingFunction> (I think it's been leaning on nsTimingFunction.h's include of nsString.h to indirectly provide these.) FrameMetrics.h will now be including: - PLDHashTable.h to provide PLDHashNumber (I think it's been leaning on nsStyleCoord.h/nsStyleConsts.h to indirectly provide this.) MozReview-Commit-ID: AoFoEe9GisK
dom/animation/ComputedTimingFunction.h
gfx/layers/FrameMetrics.h
--- a/dom/animation/ComputedTimingFunction.h
+++ b/dom/animation/ComputedTimingFunction.h
@@ -2,19 +2,24 @@
 /* vim: set ts=8 sts=2 et sw=2 tw=80: */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this file,
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #ifndef mozilla_ComputedTimingFunction_h
 #define mozilla_ComputedTimingFunction_h
 
+#include "nsDebug.h"
 #include "nsSMILKeySpline.h"  // nsSMILKeySpline
+#include "nsStringFwd.h"
 #include "nsTimingFunction.h"
 
+#include "mozilla/Assertions.h"
+#include "mozilla/Maybe.h"
+
 namespace mozilla {
 
 class ComputedTimingFunction
 {
 public:
   static ComputedTimingFunction
   CubicBezier(double x1, double y1, double x2, double y2)
   {
--- a/gfx/layers/FrameMetrics.h
+++ b/gfx/layers/FrameMetrics.h
@@ -16,16 +16,17 @@
 #include "mozilla/gfx/Rect.h"           // for RoundedIn
 #include "mozilla/gfx/ScaleFactor.h"    // for ScaleFactor
 #include "mozilla/gfx/Logging.h"        // for Log
 #include "mozilla/layers/LayersTypes.h" // for ScrollDirection
 #include "mozilla/StaticPtr.h"          // for StaticAutoPtr
 #include "mozilla/TimeStamp.h"          // for TimeStamp
 #include "nsString.h"
 #include "nsStyleCoord.h"               // for nsStyleCoord
+#include "PLDHashTable.h"               // for PLDHashNumber
 
 namespace IPC {
 template <typename T> struct ParamTraits;
 } // namespace IPC
 
 namespace mozilla {
 namespace layers {