Bug 1401129 - Restore browser.newtabpage.introShown for automation tools. r?whimboo draft
authorAndreas Tolfsen <ato@sny.no>
Thu, 08 Mar 2018 15:56:01 +0000
changeset 764920 72a8dd69c8883e3b9fc46e8a601c9b098a05e6bf
parent 764919 4c06e779089d7795c9b9365217273e23b4fb4dcd
child 764921 e3ae1759af7786f67f19f2e055a4d26342d4e540
push id101893
push userbmo:ato@sny.no
push dateThu, 08 Mar 2018 16:18:42 +0000
reviewerswhimboo
bugs1401129, 1433133
milestone60.0a1
Bug 1401129 - Restore browser.newtabpage.introShown for automation tools. r?whimboo The browser.newtabpage.introShown preference was removed in bug 1433133 but this patch restores it to the number of automation tools in tree that target out-of-tree release channels. MozReview-Commit-ID: ENPpP3ARhYa
testing/geckodriver/src/prefs.rs
testing/marionette/client/marionette_driver/geckoinstance.py
--- a/testing/geckodriver/src/prefs.rs
+++ b/testing/geckodriver/src/prefs.rs
@@ -1,12 +1,12 @@
 use mozprofile::preferences::Pref;
 
 lazy_static! {
-    pub static ref DEFAULT: [(&'static str, Pref); 81] = [
+    pub static ref DEFAULT: [(&'static str, Pref); 82] = [
         // Disable automatic downloading of new releases
         ("app.update.auto", Pref::new(false)),
 
         // Disable automatically upgrading Firefox
         ("app.update.enabled", Pref::new(false)),
 
         // Increase the APZ content response timeout in tests to 1
         // minute.  This is to accommodate the fact that test environments
@@ -31,16 +31,23 @@ lazy_static! {
         ("browser.EULA.override", Pref::new(true)),
 
         // use about:blank as new tab page
         ("browser.newtabpage.enabled", Pref::new(false)),
 
         // Never start the browser in offline mode
         ("browser.offline", Pref::new(false)),
 
+        // Assume the about:newtab pages intro panels have been shown
+        // to not depend on which test runs first and happens to open
+        // about:newtab.
+        //
+        // Removed in Firefox 60.
+        ("browser.newtabpage.introShown", Pref::new(true)),
+
         // Background thumbnails in particular cause grief, and disabling
         // thumbnails in general cannot hurt
         ("browser.pagethumbnails.capturing_disabled", Pref::new(true)),
 
         // Avoid performing Reader Mode intros during tests
         ("browser.reader.detectedFirstArticle", Pref::new(true)),
 
         // Disable safebrowsing components
--- a/testing/marionette/client/marionette_driver/geckoinstance.py
+++ b/testing/marionette/client/marionette_driver/geckoinstance.py
@@ -497,16 +497,22 @@ class DesktopInstance(GeckoInstance):
         "browser.download.panel.shown": True,
 
         # Do not show the EULA notification which can interfer with tests
         "browser.EULA.override": True,
 
         # Turn off about:newtab and make use of about:blank instead for new opened tabs
         "browser.newtabpage.enabled": False,
 
+        # Assume the about:newtab page's intro panels have been shown to not depend on
+        # which test runs first and happens to open about:newtab.
+        #
+        # Removed in Firefox 60.        
+        "browser.newtabpage.introShown": True,
+
         # Background thumbnails in particular cause grief, and disabling thumbnails
         # in general can"t hurt - we re-enable them when tests need them
         "browser.pagethumbnails.capturing_disabled": True,
 
         # Disable safebrowsing components
         "browser.safebrowsing.blockedURIs.enabled": False,
         "browser.safebrowsing.downloads.enabled": False,
         "browser.safebrowsing.passwords.enabled": False,