Bug 1443660 - Rename NavigationDelegate.onLoadUri() to onLoadRequest() r=jchen,esawin
MozReview-Commit-ID: o5NHVH6BMo
--- a/mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java
+++ b/mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java
@@ -647,17 +647,17 @@ public class CustomTabsActivity extends
}
return true;
}
@Override
public void onNewSession(final GeckoSession session, final String uri,
final GeckoSession.Response<GeckoSession> response) {
- // We should never get here because we abort loads that need a new session in onLoadUri()
+ // We should never get here because we abort loads that need a new session in onLoadRequest()
throw new IllegalStateException("Unexpected new session");
}
/* GeckoSession.ProgressDelegate */
@Override
public void onPageStart(GeckoSession session, String url) {
mCurrentUrl = url;
mCanStop = true;
--- a/mobile/android/base/java/org/mozilla/gecko/webapps/WebAppActivity.java
+++ b/mobile/android/base/java/org/mozilla/gecko/webapps/WebAppActivity.java
@@ -374,18 +374,18 @@ public class WebAppActivity extends AppC
}
@Override // GeckoSession.ContentDelegate
public void onFullScreen(GeckoSession session, boolean fullScreen) {
updateFullScreenContent(fullScreen);
}
@Override
- public boolean onLoadUri(final GeckoSession session, final String urlStr,
- final int target) {
+ public boolean onLoadRequest(final GeckoSession session, final String urlStr,
+ final int target) {
final Uri uri = Uri.parse(urlStr);
if (uri == null) {
// We can't really handle this, so deny it?
Log.w(LOGTAG, "Failed to parse URL for navigation: " + urlStr);
return true;
}
if (mManifest.isInScope(uri) && target != TARGET_WINDOW_NEW) {
@@ -425,17 +425,17 @@ public class WebAppActivity extends AppC
}
}
return true;
}
@Override
public void onNewSession(final GeckoSession session, final String uri,
final GeckoSession.Response<GeckoSession> response) {
- // We should never get here because we abort loads that need a new session in onLoadUri()
+ // We should never get here because we abort loads that need a new session in onLoadRequest()
throw new IllegalStateException("Unexpected new session");
}
private void updateFullScreen() {
boolean fullScreen = mIsFullScreenContent || mIsFullScreenMode;
if (ActivityUtils.isFullScreen(this) == fullScreen) {
return;
}
--- a/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/NavigationListenerTest.kt
+++ b/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/NavigationListenerTest.kt
@@ -38,18 +38,18 @@ class NavigationDelegateTest {
}
@Test fun load() {
sessionRule.session.loadTestPath(HELLO_HTML_PATH)
sessionRule.waitForPageStop()
sessionRule.forCallbacksDuringWait(object : Callbacks.NavigationDelegate {
@AssertCalled(count = 1, order = intArrayOf(1))
- override fun onLoadUri(session: GeckoSession, uri: String,
- where: Int): Boolean {
+ override fun onLoadRequest(session: GeckoSession, uri: String,
+ where: Int): Boolean {
assertThat("Session should not be null", session, notNullValue())
assertThat("URI should not be null", uri, notNullValue())
assertThat("URI should match", uri, endsWith(HELLO_HTML_PATH))
assertThat("Where should not be null", where, notNullValue())
assertThat("Where should match", where,
equalTo(GeckoSession.NavigationDelegate.TARGET_WINDOW_CURRENT))
return false
}
@@ -84,18 +84,18 @@ class NavigationDelegateTest {
sessionRule.session.loadTestPath(HELLO_HTML_PATH)
sessionRule.waitForPageStop()
sessionRule.session.reload()
sessionRule.waitForPageStop()
sessionRule.forCallbacksDuringWait(object : Callbacks.NavigationDelegate {
@AssertCalled(count = 1, order = intArrayOf(1))
- override fun onLoadUri(session: GeckoSession, uri: String,
- where: Int): Boolean {
+ override fun onLoadRequest(session: GeckoSession, uri: String,
+ where: Int): Boolean {
assertThat("URI should match", uri, endsWith(HELLO_HTML_PATH))
assertThat("Where should match", where,
equalTo(GeckoSession.NavigationDelegate.TARGET_WINDOW_CURRENT))
return false
}
@AssertCalled(count = 1, order = intArrayOf(2))
override fun onLocationChange(session: GeckoSession, url: String) {
@@ -133,18 +133,18 @@ class NavigationDelegateTest {
}
})
sessionRule.session.goBack()
sessionRule.waitForPageStop()
sessionRule.forCallbacksDuringWait(object : Callbacks.NavigationDelegate {
@AssertCalled(count = 1, order = intArrayOf(1))
- override fun onLoadUri(session: GeckoSession, uri: String,
- where: Int): Boolean {
+ override fun onLoadRequest(session: GeckoSession, uri: String,
+ where: Int): Boolean {
assertThat("URI should match", uri, endsWith(HELLO_HTML_PATH))
assertThat("Where should match", where,
equalTo(GeckoSession.NavigationDelegate.TARGET_WINDOW_CURRENT))
return false
}
@AssertCalled(count = 1, order = intArrayOf(2))
override fun onLocationChange(session: GeckoSession, url: String) {
@@ -167,18 +167,18 @@ class NavigationDelegateTest {
}
})
sessionRule.session.goForward()
sessionRule.waitForPageStop()
sessionRule.forCallbacksDuringWait(object : Callbacks.NavigationDelegate {
@AssertCalled(count = 1, order = intArrayOf(1))
- override fun onLoadUri(session: GeckoSession, uri: String,
- where: Int): Boolean {
+ override fun onLoadRequest(session: GeckoSession, uri: String,
+ where: Int): Boolean {
assertThat("URI should match", uri, endsWith(HELLO2_HTML_PATH))
assertThat("Where should match", where,
equalTo(GeckoSession.NavigationDelegate.TARGET_WINDOW_CURRENT))
return false
}
@AssertCalled(count = 1, order = intArrayOf(2))
override fun onLocationChange(session: GeckoSession, url: String) {
@@ -200,18 +200,18 @@ class NavigationDelegateTest {
response: GeckoSession.Response<GeckoSession>) {
}
})
}
@Test fun onLoadUri_returnTrueCancelsLoad() {
sessionRule.delegateDuringNextWait(object : Callbacks.NavigationDelegate {
@AssertCalled(count = 2)
- override fun onLoadUri(session: GeckoSession, uri: String,
- where: Int): Boolean {
+ override fun onLoadRequest(session: GeckoSession, uri: String,
+ where: Int): Boolean {
return uri.endsWith(HELLO_HTML_PATH)
}
})
sessionRule.session.loadTestPath(HELLO_HTML_PATH)
sessionRule.session.loadTestPath(HELLO2_HTML_PATH)
sessionRule.waitForPageStop()
--- a/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/TestRunnerActivity.java
+++ b/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/TestRunnerActivity.java
@@ -35,17 +35,17 @@ public class TestRunnerActivity extends
}
@Override
public void onCanGoForward(GeckoSession session, boolean canGoForward) {
}
@Override
- public boolean onLoadUri(GeckoSession session, String uri, int target) {
+ public boolean onLoadRequest(GeckoSession session, String uri, int target) {
// Allow Gecko to load all URIs
return false;
}
@Override
public void onNewSession(GeckoSession session, String uri, GeckoSession.Response<GeckoSession> response) {
response.respond(createSession(session.getSettings()));
}
--- a/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/util/Callbacks.kt
+++ b/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/util/Callbacks.kt
@@ -35,17 +35,17 @@ class Callbacks private constructor() {
}
override fun onCanGoBack(session: GeckoSession, canGoBack: Boolean) {
}
override fun onCanGoForward(session: GeckoSession, canGoForward: Boolean) {
}
- override fun onLoadUri(session: GeckoSession, uri: String, where: Int): Boolean {
+ override fun onLoadRequest(session: GeckoSession, uri: String, where: Int): Boolean {
return false;
}
override fun onNewSession(session: GeckoSession, uri: String, response: GeckoSession.Response<GeckoSession>) {
response.respond(null)
}
}
--- a/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java
@@ -146,17 +146,17 @@ public class GeckoSession extends LayerS
where = NavigationDelegate.TARGET_WINDOW_CURRENT;
break;
default:
where = NavigationDelegate.TARGET_WINDOW_NEW;
break;
}
final boolean result =
- delegate.onLoadUri(GeckoSession.this, uri, where);
+ delegate.onLoadRequest(GeckoSession.this, uri, where);
callback.sendSuccess(result);
} else if ("GeckoView:OnNewSession".equals(event)) {
final String uri = message.getString("uri");
delegate.onNewSession(GeckoSession.this, uri,
new Response<GeckoSession>() {
@Override
public void respond(GeckoSession session) {
if (session == null) {
@@ -1403,17 +1403,17 @@ public class GeckoSession extends LayerS
* @param session The GeckoSession that initiated the callback.
* @param uri The URI to be loaded.
* @param target The target where the window has requested to open. One of
* TARGET_WINDOW_*.
*
* @return Whether or not the load was handled. Returning false will allow Gecko
* to continue the load as normal.
*/
- boolean onLoadUri(GeckoSession session, String uri, int target);
+ boolean onLoadRequest(GeckoSession session, String uri, int target);
/**
* A request has been made to open a new session. The URI is provided only for
* informational purposes. Do not call GeckoSession.loadUri() here. Additionally, the
* returned GeckoSession must be a newly-created one.
*
* @param session The GeckoSession that initiated the callback.
* @param uri The URI to be loaded.
--- a/mobile/android/geckoview_example/src/main/java/org/mozilla/geckoview_example/GeckoViewActivity.java
+++ b/mobile/android/geckoview_example/src/main/java/org/mozilla/geckoview_example/GeckoViewActivity.java
@@ -350,19 +350,19 @@ public class GeckoViewActivity extends A
public void onCanGoBack(GeckoSession session, boolean canGoBack) {
}
@Override
public void onCanGoForward(GeckoSession session, boolean value) {
}
@Override
- public boolean onLoadUri(final GeckoSession session, final String uri,
- final int target) {
- Log.d(LOGTAG, "onLoadUri=" + uri + " where=" + target);
+ public boolean onLoadRequest(final GeckoSession session, final String uri,
+ final int target) {
+ Log.d(LOGTAG, "onLoadRequest=" + uri + " where=" + target);
return false;
}
@Override
public void onNewSession(final GeckoSession session, final String uri, Response<GeckoSession> response) {
response.respond(null);
}
}