Bug 1436200 - Disable failing assertions until we have the proper fix in place. r?botond draft
authorKartikaya Gupta <kgupta@mozilla.com>
Mon, 05 Mar 2018 09:47:53 -0500
changeset 763156 8d5334f056dc6b6601ef9e668968454a8fde8011
parent 763109 51200c0fdaddb2749549a82596da5323a4cbd499
push id101360
push userkgupta@mozilla.com
push dateMon, 05 Mar 2018 14:48:19 +0000
reviewersbotond
bugs1436200
milestone60.0a1
Bug 1436200 - Disable failing assertions until we have the proper fix in place. r?botond MozReview-Commit-ID: 59aKg5oSrbl
gfx/layers/apz/src/APZCTreeManager.cpp
--- a/gfx/layers/apz/src/APZCTreeManager.cpp
+++ b/gfx/layers/apz/src/APZCTreeManager.cpp
@@ -2385,19 +2385,22 @@ APZCTreeManager::GetAPZCAtPointWR(const 
   uint64_t layersId = wr::AsUint64(pipelineId);
   RefPtr<HitTestingTreeNode> node = GetTargetNode(
       ScrollableLayerGuid(layersId, 0, scrollId),
       &GuidComparatorIgnoringPresShell);
   MOZ_ASSERT(!node || node->GetApzc()); // any node returned must have an APZC
   result = node ? node->GetApzc() : nullptr;
   if (!result) {
     // It falls back to the root
-    MOZ_ASSERT(scrollId == FrameMetrics::NULL_SCROLL_ID);
+    // Re-enable these assertions once bug 1391318 is fixed. For now there are
+    // race conditions with the WR hit-testing code that make these assertions
+    // fail.
+    //MOZ_ASSERT(scrollId == FrameMetrics::NULL_SCROLL_ID);
     result = FindRootApzcForLayersId(layersId);
-    MOZ_ASSERT(result);
+    //MOZ_ASSERT(result);
   }
 
   bool isScrollbar = bool(hitInfo & gfx::CompositorHitTestInfo::eScrollbar);
   bool isScrollbarThumb = bool(hitInfo & gfx::CompositorHitTestInfo::eScrollbarThumb);
   ScrollDirection direction = (hitInfo & gfx::CompositorHitTestInfo::eScrollbarVertical)
                             ? ScrollDirection::eVertical
                             : ScrollDirection::eHorizontal;
   if (isScrollbar || isScrollbarThumb) {