Bug 521435 Update warnings for LTO draft
authorTom Ritter <tom@mozilla.com>
Thu, 01 Mar 2018 12:44:28 -0600
changeset 763022 1b2e6b2148ef609108a2ec0d0da0e87d71c49045
parent 763021 355d512fcbb5e45a6fafe5e1c53ee4b87fef4356
child 763335 dbb55cb3515004d99dc66aee81a1ac78fa40653a
child 763337 1cebfe681d7ca818f6a3a2a57ee0d2400bbf8380
child 763338 5260b811ea3b280ac71bf13c36448c1f9e88c4c8
child 763346 5c838a148e9782676de201c7a85d3ecba728885c
push id101309
push userbmo:tom@mozilla.com
push dateMon, 05 Mar 2018 00:57:59 +0000
bugs521435
milestone60.0a1
Bug 521435 Update warnings for LTO MozReview-Commit-ID: EQtAivAY8cM
build/moz.configure/warnings.configure
--- a/build/moz.configure/warnings.configure
+++ b/build/moz.configure/warnings.configure
@@ -88,16 +88,26 @@ check_and_add_gcc_warning('-Wno-error=ma
 
 # we don't want our builds held hostage when a platform-specific API
 # becomes deprecated.
 check_and_add_gcc_warning('-Wno-error=deprecated-declarations')
 
 # false positives depending on optimization
 check_and_add_gcc_warning('-Wno-error=array-bounds')
 
+# only enabled in LTO build, and we apparently don't care about these warnings
+check_and_add_gcc_warning('-Wno-error=odr')
+check_and_add_gcc_warning('-Wno-error=lto-type-mismatch')
+
+# add suggestions for final keywords in LTO builds
+check_and_add_gcc_warning('-Wsuggest-final-types')
+check_and_add_gcc_warning('-Wno-error=suggest-final-types')
+check_and_add_gcc_warning('-Wsuggest-final-methods')
+check_and_add_gcc_warning('-Wno-error=suggest-final-methods')
+
 # can't get rid of those PGO warnings
 check_and_add_gcc_warning('-Wno-error=coverage-mismatch', when='MOZ_PGO')
 
 # false positives depending on optimizations
 check_and_add_gcc_warning('-Wno-error=free-nonheap-object')
 
 # catches format/argument mismatches with printf
 c_format_warning, cxx_format_warning = check_and_add_gcc_warning(