Bug 1442403 - Stop building xpcom/typelib/xpt/ with MOZ_NO_MOZALLOC. r=glandium draft
authorAndrew McCreight <continuation@gmail.com>
Thu, 01 Mar 2018 12:59:26 -0800
changeset 762248 79f5d8b4d20a16fee8a3ded4162871e9470719be
parent 762247 dea496e2d271796a8b7b4d3ff27263086c3d4d21
push id101107
push userbmo:continuation@gmail.com
push dateThu, 01 Mar 2018 22:22:59 +0000
reviewersglandium
bugs1442403, 1081000, 1248534
milestone60.0a1
Bug 1442403 - Stop building xpcom/typelib/xpt/ with MOZ_NO_MOZALLOC. r=glandium This was added in bug 1081000 to support linking XPT tests, but those tests were removed in bug 1248534, part 1, so this shouldn't be needed any more. MozReview-Commit-ID: I1V2XVBaMG7
xpcom/typelib/xpt/moz.build
--- a/xpcom/typelib/xpt/moz.build
+++ b/xpcom/typelib/xpt/moz.build
@@ -22,16 +22,9 @@ FINAL_LIBRARY = 'xul'
 LOCAL_INCLUDES += [
     '!/xpcom/base',
     '/xpcom/base',
 ]
 
 if CONFIG['CC_TYPE'] in ('msvc', 'clang-cl'):
     CFLAGS += ['-Zl']
 
-# Code with FINAL_LIBRARY = 'xul' shouldn't do this, but the code
-# here doesn't use malloc functions anyways, while not setting
-# MOZ_NO_MOZALLOC makes the code include mozalloc.h, which includes
-# inline operator new definitions that MSVC linker doesn't strip
-# when linking the xpt tests.
-DEFINES['MOZ_NO_MOZALLOC'] = True
-
 DIST_INSTALL = True