Bug 1441974 - Avoid duplicate clicks in sidebar toggle. r=miker draft
authorJ. Ryan Stinnett <jryans@gmail.com>
Wed, 28 Feb 2018 13:45:47 -0600
changeset 761163 40125d7c802b557244dc7655edaefea92111ed84
parent 761143 e45b91be417381ac25347ddeca34392aa636461d
child 761169 dc1bd4d2a404018bbb04b50b6f87a818a74b6dec
push id100895
push userbmo:jryans@gmail.com
push dateWed, 28 Feb 2018 19:53:29 +0000
reviewersmiker
bugs1441974, 1420130
milestone60.0a1
Bug 1441974 - Avoid duplicate clicks in sidebar toggle. r=miker After the React monkeypatch removal (bug 1420130), some events can be duplicated because both privileged and non-privileged versions are dispatched. To work around this, we can stop propagation for the event in cases like this where it is safe to do so. MozReview-Commit-ID: L6cHpuTw1D2
devtools/client/shared/components/SidebarToggle.js
--- a/devtools/client/shared/components/SidebarToggle.js
+++ b/devtools/client/shared/components/SidebarToggle.js
@@ -39,16 +39,17 @@ class SidebarToggle extends Component {
     };
 
     this.onClick = this.onClick.bind(this);
   }
 
   // Events
 
   onClick(event) {
+    event.stopPropagation();
     this.props.onClick(event);
   }
 
   // Rendering
 
   render() {
     let title = this.state.collapsed ?
       this.props.expandPaneTitle :