bug 1440832 - Only log when clamping on debug builds r?gfritzsche draft
authorChris H-C <chutten@mozilla.com>
Wed, 28 Feb 2018 13:35:32 -0500
changeset 761129 3cc6913c908cb351590147089058e635dcc84f4e
parent 761128 c50f5f846c2e6b4c8da1e80b6790926ad84c3450
push id100874
push userbmo:chutten@mozilla.com
push dateWed, 28 Feb 2018 18:37:17 +0000
reviewersgfritzsche
bugs1440832
milestone60.0a1
bug 1440832 - Only log when clamping on debug builds r?gfritzsche MozReview-Commit-ID: qkKTHH4DNU
toolkit/components/telemetry/TelemetryHistogram.cpp
--- a/toolkit/components/telemetry/TelemetryHistogram.cpp
+++ b/toolkit/components/telemetry/TelemetryHistogram.cpp
@@ -1200,18 +1200,20 @@ internal_JSHistogram_Add(JSContext *cx, 
       return true;
     }
 
     if (args[0].isNumber() && args[0].toNumber() > UINT32_MAX) {
       // Clamp large numerical arguments to value's acceptable values.
       // JS::ToUint32 will take arg[0] modulo 2^32 before returning it, which
       // may result in a smaller final value.
       value = UINT32_MAX;
+#ifdef DEBUG
       LogToBrowserConsole(nsIScriptError::errorFlag,
         NS_LITERAL_STRING("Clamped larged numeric value."));
+#endif
     } else if (!JS::ToUint32(cx, args[0], &value)) {
       LogToBrowserConsole(nsIScriptError::errorFlag, NS_LITERAL_STRING("Failed to convert argument"));
       return true;
     }
   }
 
   {
     StaticMutexAutoLock locker(gTelemetryHistogramMutex);