--- a/modules/libpref/Preferences.cpp
+++ b/modules/libpref/Preferences.cpp
@@ -995,22 +995,19 @@ pref_SetPref(const char* aPrefName,
return NS_OK;
}
// Removes |node| from callback list. Returns the node after the deleted one.
static CallbackNode*
pref_RemoveCallbackNode(CallbackNode* aNode, CallbackNode* aPrevNode)
{
- NS_PRECONDITION(!aPrevNode || aPrevNode->Next() == aNode, "invalid params");
- NS_PRECONDITION(aPrevNode || gFirstCallback == aNode, "invalid params");
-
- NS_ASSERTION(
- !gCallbacksInProgress,
- "modifying the callback list while gCallbacksInProgress is true");
+ MOZ_ASSERT(!aPrevNode || aPrevNode->Next() == aNode);
+ MOZ_ASSERT(aPrevNode || gFirstCallback == aNode);
+ MOZ_ASSERT(!gCallbacksInProgress);
CallbackNode* next_node = aNode->Next();
if (aPrevNode) {
aPrevNode->SetNext(next_node);
} else {
gFirstCallback = next_node;
}
if (gLastPriorityNode == aNode) {
@@ -2301,17 +2298,17 @@ nsPrefBranch::FreeObserverList()
iter.Remove();
}
mFreeingObserverList = false;
}
void
nsPrefBranch::RemoveExpiredCallback(PrefCallback* aCallback)
{
- NS_PRECONDITION(aCallback->IsExpired(), "Callback should be expired.");
+ MOZ_ASSERT(aCallback->IsExpired());
mObservers.Remove(aCallback);
}
nsresult
nsPrefBranch::GetDefaultFromPropertiesFile(const char* aPrefName,
nsAString& aReturn)
{
// The default value contains a URL to a .properties file.
@@ -2337,17 +2334,17 @@ nsPrefBranch::GetDefaultFromPropertiesFi
}
return bundle->GetStringFromName(aPrefName, aReturn);
}
nsPrefBranch::PrefName
nsPrefBranch::GetPrefName(const char* aPrefName) const
{
- NS_ASSERTION(aPrefName, "null pref name!");
+ MOZ_ASSERT(aPrefName);
// For speed, avoid strcpy if we can.
if (mPrefRoot.IsEmpty()) {
return PrefName(aPrefName);
}
return PrefName(mPrefRoot + nsDependentCString(aPrefName));
}
@@ -2539,17 +2536,17 @@ public:
for (nsCString& pref : aPrefs) {
outStream->Write(pref.get(), pref.Length(), &writeAmount);
outStream->Write(NS_LINEBREAK, NS_LINEBREAK_LEN, &writeAmount);
}
// Tell the safe output stream to overwrite the real prefs file.
// (It'll abort if there were any errors during writing.)
nsCOMPtr<nsISafeOutputStream> safeStream = do_QueryInterface(outStream);
- NS_ASSERTION(safeStream, "expected a safe output stream!");
+ MOZ_ASSERT(safeStream, "expected a safe output stream!");
if (safeStream) {
rv = safeStream->Finish();
}
#ifdef DEBUG
if (NS_FAILED(rv)) {
NS_WARNING("failed to save prefs file! possible data loss");
}
@@ -3036,18 +3033,17 @@ Preferences::Preferences()
Preferences::~Preferences()
{
MOZ_ASSERT(!sPreferences);
delete gCacheData;
gCacheData = nullptr;
- NS_ASSERTION(!gCallbacksInProgress,
- "~Preferences was called while gCallbacksInProgress is true!");
+ MOZ_ASSERT(!gCallbacksInProgress);
CallbackNode* node = gFirstCallback;
while (node) {
CallbackNode* next_node = node->Next();
delete node;
node = next_node;
}
gLastPriorityNode = gFirstCallback = nullptr;
@@ -3661,17 +3657,17 @@ pref_LoadPrefsInDir(nsIFile* aDir,
rv = dirIterator->GetNext(getter_AddRefs(supports));
prefFile = do_QueryInterface(supports);
if (NS_FAILED(rv)) {
break;
}
nsAutoCString leafName;
prefFile->GetNativeLeafName(leafName);
- NS_ASSERTION(
+ MOZ_ASSERT(
!leafName.IsEmpty(),
"Failure in default prefs: directory enumerator returned empty file?");
// Skip non-js files.
if (StringEndsWith(leafName,
NS_LITERAL_CSTRING(".js"),
nsCaseInsensitiveCStringComparator())) {
bool shouldParse = true;
@@ -3968,41 +3964,41 @@ Preferences::InitInitialObjects()
nullptr, NS_PREFSERVICE_APPDEFAULTS_TOPIC_ID, nullptr);
return Ok();
}
/* static */ nsresult
Preferences::GetBool(const char* aPrefName, bool* aResult, PrefValueKind aKind)
{
- NS_PRECONDITION(aResult, "aResult must not be NULL");
+ MOZ_ASSERT(aResult);
NS_ENSURE_TRUE(InitStaticMembers(), NS_ERROR_NOT_AVAILABLE);
Pref* pref = pref_HashTableLookup(aPrefName);
return pref ? pref->GetBoolValue(aKind, aResult) : NS_ERROR_UNEXPECTED;
}
/* static */ nsresult
Preferences::GetInt(const char* aPrefName,
int32_t* aResult,
PrefValueKind aKind)
{
- NS_PRECONDITION(aResult, "aResult must not be NULL");
+ MOZ_ASSERT(aResult);
NS_ENSURE_TRUE(InitStaticMembers(), NS_ERROR_NOT_AVAILABLE);
Pref* pref = pref_HashTableLookup(aPrefName);
return pref ? pref->GetIntValue(aKind, aResult) : NS_ERROR_UNEXPECTED;
}
/* static */ nsresult
Preferences::GetFloat(const char* aPrefName,
float* aResult,
PrefValueKind aKind)
{
- NS_PRECONDITION(aResult, "aResult must not be NULL");
+ MOZ_ASSERT(aResult);
nsAutoCString result;
nsresult rv = Preferences::GetCString(aPrefName, result, aKind);
if (NS_SUCCEEDED(rv)) {
*aResult = result.ToFloat(&rv);
}
return rv;
}
@@ -4053,17 +4049,17 @@ Preferences::GetLocalizedString(const ch
{
NS_ENSURE_TRUE(InitStaticMembers(), NS_ERROR_NOT_AVAILABLE);
nsCOMPtr<nsIPrefLocalizedString> prefLocalString;
nsresult rv =
GetRootBranch(aKind)->GetComplexValue(aPrefName,
NS_GET_IID(nsIPrefLocalizedString),
getter_AddRefs(prefLocalString));
if (NS_SUCCEEDED(rv)) {
- NS_ASSERTION(prefLocalString, "Succeeded but the result is NULL");
+ MOZ_ASSERT(prefLocalString, "Succeeded but the result is NULL");
prefLocalString->GetData(aResult);
}
return rv;
}
/* static */ nsresult
Preferences::GetComplex(const char* aPrefName,
const nsIID& aType,
@@ -4466,17 +4462,17 @@ BoolVarChanged(const char* aPref, void*
CacheData* cache = static_cast<CacheData*>(aClosure);
*static_cast<bool*>(cache->mCacheLocation) =
Preferences::GetBool(aPref, cache->mDefaultValueBool);
}
/* static */ nsresult
Preferences::AddBoolVarCache(bool* aCache, const char* aPref, bool aDefault)
{
- NS_ASSERTION(aCache, "aCache must not be NULL");
+ MOZ_ASSERT(aCache);
#ifdef DEBUG
AssertNotAlreadyCached("bool", aPref, aCache);
#endif
*aCache = GetBool(aPref, aDefault);
CacheData* data = new CacheData();
data->mCacheLocation = aCache;
data->mDefaultValueBool = aDefault;
CacheDataAppendElement(data);
@@ -4498,17 +4494,17 @@ AtomicBoolVarChanged(const char* aPref,
}
template<MemoryOrdering Order>
/* static */ nsresult
Preferences::AddAtomicBoolVarCache(Atomic<bool, Order>* aCache,
const char* aPref,
bool aDefault)
{
- NS_ASSERTION(aCache, "aCache must not be NULL");
+ MOZ_ASSERT(aCache);
#ifdef DEBUG
AssertNotAlreadyCached("bool", aPref, aCache);
#endif
*aCache = Preferences::GetBool(aPref, aDefault);
CacheData* data = new CacheData();
data->mCacheLocation = aCache;
data->mDefaultValueBool = aDefault;
CacheDataAppendElement(data);
@@ -4528,17 +4524,17 @@ IntVarChanged(const char* aPref, void* a
Preferences::GetInt(aPref, cache->mDefaultValueInt);
}
/* static */ nsresult
Preferences::AddIntVarCache(int32_t* aCache,
const char* aPref,
int32_t aDefault)
{
- NS_ASSERTION(aCache, "aCache must not be NULL");
+ MOZ_ASSERT(aCache);
#ifdef DEBUG
AssertNotAlreadyCached("int", aPref, aCache);
#endif
*aCache = Preferences::GetInt(aPref, aDefault);
CacheData* data = new CacheData();
data->mCacheLocation = aCache;
data->mDefaultValueInt = aDefault;
CacheDataAppendElement(data);
@@ -4557,17 +4553,17 @@ AtomicIntVarChanged(const char* aPref, v
}
template<MemoryOrdering Order>
/* static */ nsresult
Preferences::AddAtomicIntVarCache(Atomic<int32_t, Order>* aCache,
const char* aPref,
int32_t aDefault)
{
- NS_ASSERTION(aCache, "aCache must not be NULL");
+ MOZ_ASSERT(aCache);
#ifdef DEBUG
AssertNotAlreadyCached("int", aPref, aCache);
#endif
*aCache = Preferences::GetInt(aPref, aDefault);
CacheData* data = new CacheData();
data->mCacheLocation = aCache;
data->mDefaultValueUint = aDefault;
CacheDataAppendElement(data);
@@ -4587,17 +4583,17 @@ UintVarChanged(const char* aPref, void*
Preferences::GetUint(aPref, cache->mDefaultValueUint);
}
/* static */ nsresult
Preferences::AddUintVarCache(uint32_t* aCache,
const char* aPref,
uint32_t aDefault)
{
- NS_ASSERTION(aCache, "aCache must not be NULL");
+ MOZ_ASSERT(aCache);
#ifdef DEBUG
AssertNotAlreadyCached("uint", aPref, aCache);
#endif
*aCache = Preferences::GetUint(aPref, aDefault);
CacheData* data = new CacheData();
data->mCacheLocation = aCache;
data->mDefaultValueUint = aDefault;
CacheDataAppendElement(data);
@@ -4619,17 +4615,17 @@ AtomicUintVarChanged(const char* aPref,
}
template<MemoryOrdering Order>
/* static */ nsresult
Preferences::AddAtomicUintVarCache(Atomic<uint32_t, Order>* aCache,
const char* aPref,
uint32_t aDefault)
{
- NS_ASSERTION(aCache, "aCache must not be NULL");
+ MOZ_ASSERT(aCache);
#ifdef DEBUG
AssertNotAlreadyCached("uint", aPref, aCache);
#endif
*aCache = Preferences::GetUint(aPref, aDefault);
CacheData* data = new CacheData();
data->mCacheLocation = aCache;
data->mDefaultValueUint = aDefault;
CacheDataAppendElement(data);
@@ -4678,17 +4674,17 @@ FloatVarChanged(const char* aPref, void*
CacheData* cache = static_cast<CacheData*>(aClosure);
*static_cast<float*>(cache->mCacheLocation) =
Preferences::GetFloat(aPref, cache->mDefaultValueFloat);
}
/* static */ nsresult
Preferences::AddFloatVarCache(float* aCache, const char* aPref, float aDefault)
{
- NS_ASSERTION(aCache, "aCache must not be NULL");
+ MOZ_ASSERT(aCache);
#ifdef DEBUG
AssertNotAlreadyCached("float", aPref, aCache);
#endif
*aCache = Preferences::GetFloat(aPref, aDefault);
CacheData* data = new CacheData();
data->mCacheLocation = aCache;
data->mDefaultValueFloat = aDefault;
CacheDataAppendElement(data);