Bug 1429904 - Remove a comment about std::string. r?njn draft
authorMarkus Stange <mstange@themasta.com>
Wed, 28 Feb 2018 00:30:55 -0500
changeset 762103 d8b516a654c4d4ed73dd10ee308080db728c5f44
parent 762102 bf93be38d9f6caaa414df5c517ae223bcf131ef5
child 762104 2597f6b7180d88b46e79460c8557ca2445bd8566
push id101088
push userbmo:mstange@themasta.com
push dateThu, 01 Mar 2018 20:52:26 +0000
reviewersnjn
bugs1429904
milestone60.0a1
Bug 1429904 - Remove a comment about std::string. r?njn nsCString is the idiomatic string class we want to use anyway. There's no need to think about std::string here. MozReview-Commit-ID: 1rjZAyqp13d
tools/profiler/core/ProfileBufferEntry.h
--- a/tools/profiler/core/ProfileBufferEntry.h
+++ b/tools/profiler/core/ProfileBufferEntry.h
@@ -165,18 +165,16 @@ public:
     bool operator==(const JITAddress& aRhs) const
     {
       return mAddress == aRhs.mAddress && mStreamingGen == aRhs.mStreamingGen;
     }
     bool operator!=(const JITAddress& aRhs) const { return !(*this == aRhs); }
   };
 
   struct FrameKey {
-    // This cannot be a std::string, as it is not memmove compatible, which
-    // is used by nsHashTable
     const nsCString mLocation;
     const mozilla::Maybe<unsigned> mLine;
     const mozilla::Maybe<unsigned> mCategory;
     const mozilla::Maybe<JITAddress> mJITAddress;
     const mozilla::Maybe<uint32_t> mJITDepth;
 
     explicit FrameKey(const char* aLocation)
      : mLocation(aLocation)