Bug 1429904 - Remove unused operator< from StackKey and FrameKey. r?njn draft
authorMarkus Stange <mstange@themasta.com>
Tue, 27 Feb 2018 22:41:35 -0500
changeset 762098 9ba70eaf74c5b367aa303dc02a4d6bdd4a0101fe
parent 762050 fb9c7930fe77e2074e02a3cde903c4deccf31a3d
child 762099 f5074e4a6df03782e8ae18384c71f868ab8b0942
push id101088
push userbmo:mstange@themasta.com
push dateThu, 01 Mar 2018 20:52:26 +0000
reviewersnjn
bugs1429904
milestone60.0a1
Bug 1429904 - Remove unused operator< from StackKey and FrameKey. r?njn nsGenericHashKey never calls this operator, as far as I can tell. MozReview-Commit-ID: NDybMI8DOA
tools/profiler/core/ProfileBufferEntry.h
--- a/tools/profiler/core/ProfileBufferEntry.h
+++ b/tools/profiler/core/ProfileBufferEntry.h
@@ -198,19 +198,16 @@ public:
      : mJITAddress(mozilla::Some(aJITAddress))
      , mJITDepth(mozilla::Some(aJITDepth))
     {
       mHash = Hash();
     }
 
     uint32_t Hash() const;
     bool operator==(const FrameKey& aOther) const;
-    bool operator<(const FrameKey& aOther) const {
-      return mHash < aOther.mHash;
-    }
 
   private:
     uint32_t mHash;
   };
 
   struct StackKey {
     mozilla::Maybe<uint32_t> mPrefixStackIndex;
     uint32_t mFrameIndex;
@@ -228,20 +225,16 @@ public:
 
     uint32_t Hash() const { return mHash; }
 
     bool operator==(const StackKey& aOther) const
     {
       return mPrefixStackIndex == aOther.mPrefixStackIndex &&
              mFrameIndex == aOther.mFrameIndex;
     }
-    bool operator<(const StackKey& aOther) const
-    {
-      return mHash < aOther.mHash;
-    }
 
   private:
     uint32_t mHash;
   };
 
   explicit UniqueStacks();
 
   // Needs to be called when using a UniqueStacks object again after having