Bug 1441275 - list outputs of embedjs.py correctly; r?Build draft
authorMike Shal <mshal@mozilla.com>
Fri, 23 Feb 2018 13:35:37 -0500
changeset 760121 e7c1bea9ab51a2f43ed4dc8a134a6d5a10732987
parent 760120 c3214e1c1405365f741741a3d70ef6f5ed76d7ee
push id100546
push userbmo:mshal@mozilla.com
push dateMon, 26 Feb 2018 21:53:22 +0000
reviewersBuild
bugs1441275
milestone60.0a1
Bug 1441275 - list outputs of embedjs.py correctly; r?Build embedjs.py produces two outputs, so we should list them both in the GENERATED_FILES rule. This avoids unspecified output errors when using the tup backend. MozReview-Commit-ID: IA70e6IcuC
js/src/shell/moz.build
--- a/js/src/shell/moz.build
+++ b/js/src/shell/moz.build
@@ -37,18 +37,18 @@ OS_LIBS += CONFIG['EDITLINE_LIBS']
 OS_LIBS += CONFIG['MOZ_ZLIB_LIBS']
 
 if CONFIG['ENABLE_INTL_API'] and CONFIG['MOZ_ICU_DATA_ARCHIVE']:
     # The ICU libraries linked into libmozjs will not include the ICU data,
     # so link it directly.
     USE_LIBS += ['icudata']
 
 # Prepare module loader JS code for embedding
-GENERATED_FILES += ['shellmoduleloader.out.h']
-shellmoduleloader = GENERATED_FILES['shellmoduleloader.out.h']
+GENERATED_FILES += [('shellmoduleloader.out.h', 'shellmoduleloader.js')]
+shellmoduleloader = GENERATED_FILES[('shellmoduleloader.out.h', 'shellmoduleloader.js')]
 shellmoduleloader.script = '../builtin/embedjs.py:generate_shellmoduleloader'
 shellmoduleloader.inputs = [
     '../js.msg',
     'ModuleLoader.js',
 ]
 
 if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
     CXXFLAGS += ['-Wno-shadow', '-Werror=format']