Bug 1438679 - [mozdevice] processExist() has to return a boolean and not remote process id. draft
authorHenrik Skupin <mail@hskupin.info>
Mon, 26 Feb 2018 12:09:48 +0100
changeset 759685 3ab3530b3d7e512c7f305702a978b75e5f002c7b
parent 758791 f7c5598e45c323547dc6d030bf8442850c15813b
child 759686 4d4e9e636476d1051e0e1951b1c3f9b288c77bf4
push id100431
push userbmo:hskupin@gmail.com
push dateMon, 26 Feb 2018 12:24:55 +0000
bugs1438679
milestone60.0a1
Bug 1438679 - [mozdevice] processExist() has to return a boolean and not remote process id. MozReview-Commit-ID: I1Z4TLZq9uS
testing/mozbase/mozdevice/mozdevice/devicemanager.py
--- a/testing/mozbase/mozdevice/mozdevice/devicemanager.py
+++ b/testing/mozbase/mozdevice/mozdevice/devicemanager.py
@@ -460,19 +460,17 @@ class DeviceManager(object):
                 processInfo = proc
                 break
         return processInfo
 
     def processExist(self, processName):
         """
         Returns True if process with name processName is running on device.
         """
-        processInfo = self.processInfo(processName)
-        if processInfo:
-            return processInfo[0]
+        return self.processInfo(processName) is not None
 
     @abstractmethod
     def killProcess(self, processName, sig=None, native=False):
         """
         Kills the process named processName. If sig is not None, process is
         killed with the specified signal.
 
         :param processName: path or name of the process to kill