Bug 1441019 - Differentiate WorkerDebuggerTransport implementations. r?whimboo draft
authorAndreas Tolfsen <ato@sny.no>
Mon, 26 Feb 2018 11:36:24 +0000
changeset 759871 f260b7a60253a1d9235fdd5fe2f3e536224eb243
parent 759870 37ca7d04de5f7a1003fe82e7c6a4c0c03507d9c8
child 759872 30b2e6eaaae5f4f99fd1bd0aa3ef01b76dbb41fc
push id100500
push userbmo:ato@sny.no
push dateMon, 26 Feb 2018 19:31:26 +0000
reviewerswhimboo
bugs1441019
milestone60.0a1
Bug 1441019 - Differentiate WorkerDebuggerTransport implementations. r?whimboo In the transport module there are two implementations of WorkDebuggerTransport: one for the main thread and another that is suitable for worker threads. This confuses JSDoc because they both exist in the same anonymous scope. MozReview-Commit-ID: 2UE4D6K97Qb
testing/marionette/transport.js
--- a/testing/marionette/transport.js
+++ b/testing/marionette/transport.js
@@ -816,16 +816,18 @@ ChildDebuggerTransport.prototype = {
 // messages from multiple connections to be multiplexed on a single channel.
 
 if (!this.isWorker) {
   // Main thread
   (function() {
     /**
      * A transport that uses a WorkerDebugger to send packets from the main
      * thread to a worker thread.
+     *
+     * @class WorkerDebuggerTransport
      */
     function WorkerDebuggerTransport(dbg, id) {
       this._dbg = dbg;
       this._id = id;
       this.onMessage = this._onMessage.bind(this);
     }
 
     WorkerDebuggerTransport.prototype = {
@@ -868,16 +870,18 @@ if (!this.isWorker) {
 
   }).call(this);
 } else {
   // Worker thread
   (function() {
     /**
      * A transport that uses a WorkerDebuggerGlobalScope to send packets
      * from a worker thread to the main thread.
+     *
+     * @class WorkerDebuggerTransportThread
      */
     function WorkerDebuggerTransport(scope, id) {
       this._scope = scope;
       this._id = id;
       this._onMessage = this._onMessage.bind(this);
     }
 
     WorkerDebuggerTransport.prototype = {