Bug 1437382 - Part 1 - Cleanup GeckoActivityMonitor. r?jchen draft
authorJan Henning <jh+bugzilla@buttercookie.de>
Sun, 11 Feb 2018 17:59:44 +0100
changeset 759441 7dcd3789cb9b6a2f1c0d177b331c0fda704396b6
parent 759440 ef9de0f3f2a8b5d234a854b2e730c19ccc56a094
child 759442 238e2d59be7746fe7ffc5a1556ac3f3befe84fbf
push id100352
push usermozilla@buttercookie.de
push dateSat, 24 Feb 2018 11:43:59 +0000
reviewersjchen
bugs1437382
milestone60.0a1
Bug 1437382 - Part 1 - Cleanup GeckoActivityMonitor. r?jchen MozReview-Commit-ID: HOfaqlUgzVW
mobile/android/base/java/org/mozilla/gecko/GeckoActivityMonitor.java
--- a/mobile/android/base/java/org/mozilla/gecko/GeckoActivityMonitor.java
+++ b/mobile/android/base/java/org/mozilla/gecko/GeckoActivityMonitor.java
@@ -12,17 +12,16 @@ import android.os.Bundle;
 
 import java.lang.ref.WeakReference;
 
 public class GeckoActivityMonitor implements Application.ActivityLifecycleCallbacks {
     private static final String LOGTAG = "GeckoActivityMonitor";
 
     private static final GeckoActivityMonitor instance = new GeckoActivityMonitor();
 
-    private GeckoApplication appContext;
     private WeakReference<Activity> currentActivity = new WeakReference<>(null);
 
     public static GeckoActivityMonitor getInstance() {
         return instance;
     }
 
     private GeckoActivityMonitor() { }
 
@@ -56,17 +55,17 @@ public class GeckoActivityMonitor implem
 
     @Override
     public void onActivityPaused(Activity activity) { }
 
     @Override
     public void onActivityStopped(Activity activity) {
         // onStop for the previous activity is called after onStart/onResume for
         // the new/resumed activity, so if we're switching activities within our
-        // app, mCurrentActivity should already refer to the next activity at
+        // app, currentActivity should already refer to the next activity at
         // this point.
         // If it doesn't, it means we've been backgrounded.
         if (currentActivity.get() == activity) {
             currentActivity.clear();
             ((GeckoApplication) activity.getApplication()).onApplicationBackground();
         }
     }