Bug 1440491 - Remove [persist] attribute from elements without IDs in browser.xul; draft
authorBrian Grinstead <bgrinstead@mozilla.com>
Thu, 22 Feb 2018 15:12:52 -0800
changeset 758725 0e931e6cd68f9764d60b84bddddd78bdd5acee77
parent 758497 5e9bd04333f20e00911b8c1dfbf2b2e070c61e2d
push id100155
push userbgrinstead@mozilla.com
push dateThu, 22 Feb 2018 23:13:00 +0000
bugs1440491
milestone60.0a1
Bug 1440491 - Remove [persist] attribute from elements without IDs in browser.xul; The XULStore is keyed on URL first, then element ID second. Having an empty ID leads to bad data in xulstore.json. MozReview-Commit-ID: CfkLvMsSvVA
browser/base/content/browser.xul
--- a/browser/base/content/browser.xul
+++ b/browser/base/content/browser.xul
@@ -615,17 +615,16 @@
 # The entire main menubar is placed into browser-menubar.inc, so that it can be shared by
 # hiddenWindow.xul.
 #include browser-menubar.inc
       </toolbaritem>
 
 #ifdef CAN_DRAW_IN_TITLEBAR
 #ifndef XP_MACOSX
       <hbox class="titlebar-placeholder" type="caption-buttons" ordinal="1000"
-            persist="width"
             skipintoolbarset="true"/>
 #endif
 #endif
     </toolbar>
 
     <toolbar id="TabsToolbar"
              fullscreentoolbar="true"
              customizable="true"
@@ -689,25 +688,23 @@
 
       <button class="accessibility-indicator" tooltiptext="&accessibilityIndicator.tooltip;"
               ordinal="1000"
               aria-live="polite" skipintoolbarset="true"/>
       <hbox class="private-browsing-indicator" skipintoolbarset="true"
             ordinal="1000"/>
 #ifdef CAN_DRAW_IN_TITLEBAR
       <hbox class="titlebar-placeholder" type="caption-buttons"
-            persist="width"
 #ifndef XP_MACOSX
             ordinal="1000"
 #endif
             skipintoolbarset="true"/>
 
 #ifdef XP_MACOSX
       <hbox class="titlebar-placeholder" type="fullscreen-button"
-            persist="width"
             skipintoolbarset="true"/>
 #endif
 #endif
     </toolbar>
 
     <toolbar id="nav-bar"
              aria-label="&navbarCmd.label;"
              fullscreentoolbar="true" mode="icons" customizable="true"