Bug 1440383 - Remove XBL accessibility role="xul:pane" and role="none" r=surkov draft
authorTimothy Guan-tin Chien <timdream@gmail.com>
Wed, 28 Feb 2018 13:09:29 -0800
changeset 762051 e6c6cefc73618f1815726566f6bc9e00561b236c
parent 762050 fb9c7930fe77e2074e02a3cde903c4deccf31a3d
child 762121 971c803c0e90572cfb2403305c55d33a29412e95
child 762535 adbe14b1537b1cb1ec3f390ed3703edbfeb799d8
push id101065
push usertimdream@gmail.com
push dateThu, 01 Mar 2018 18:37:54 +0000
reviewerssurkov
bugs1440383
milestone60.0a1
Bug 1440383 - Remove XBL accessibility role="xul:pane" and role="none" r=surkov MozReview-Commit-ID: GJ0aouAzS77
accessible/base/nsAccessibilityService.cpp
--- a/accessible/base/nsAccessibilityService.cpp
+++ b/accessible/base/nsAccessibilityService.cpp
@@ -1467,34 +1467,31 @@ nsAccessibilityService::Shutdown()
 }
 
 already_AddRefed<Accessible>
 nsAccessibilityService::CreateAccessibleByType(nsIContent* aContent,
                                                DocAccessible* aDoc)
 {
   nsAutoString role;
   nsCoreUtils::XBLBindingRole(aContent, role);
-  if (role.IsEmpty() || role.EqualsLiteral("none"))
+  if (role.IsEmpty())
     return nullptr;
 
   RefPtr<Accessible> accessible;
 #ifdef MOZ_XUL
   // XUL controls
   if (role.EqualsLiteral("xul:colorpicker")) {
     accessible = new XULColorPickerAccessible(aContent, aDoc);
 
   } else if (role.EqualsLiteral("xul:colorpickertile")) {
     accessible = new XULColorPickerTileAccessible(aContent, aDoc);
 
   } else if (role.EqualsLiteral("xul:link")) {
     accessible = new XULLinkAccessible(aContent, aDoc);
 
-  } else if(role.EqualsLiteral("xul:pane")) {
-    accessible = new EnumRoleAccessible<roles::PANE>(aContent, aDoc);
-
   } else if (role.EqualsLiteral("xul:panel")) {
     if (aContent->IsElement() &&
         aContent->AsElement()->AttrValueIs(kNameSpaceID_None,
                                            nsGkAtoms::noautofocus,
                                            nsGkAtoms::_true, eCaseMatters))
       accessible = new XULAlertAccessible(aContent, aDoc);
     else
       accessible = new EnumRoleAccessible<roles::PANE>(aContent, aDoc);