Bug 1439410 - 3a. Make GeckoSessionSettings.Key<> public; r=snorp draft
authorJim Chen <nchen@mozilla.com>
Thu, 22 Feb 2018 18:39:11 -0500
changeset 758759 23e2489eed328bf0a08358c58c633d527d8a85c2
parent 758758 99c81c34ab2203e3517e07d286f865f5e93869c8
child 758760 ceda0c38a6e3bd32fb9d9a065df7babcc075bd5e
push id100161
push userbmo:nchen@mozilla.com
push dateThu, 22 Feb 2018 23:39:58 +0000
reviewerssnorp
bugs1439410
milestone60.0a1
Bug 1439410 - 3a. Make GeckoSessionSettings.Key<> public; r=snorp GeckoSession consumers may want to refer to individual keys through a GeckoSessionSettings.Key<> variable. MozReview-Commit-ID: HK5wcs0uugD
mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSessionSettings.java
--- a/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSessionSettings.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSessionSettings.java
@@ -22,26 +22,27 @@ public final class GeckoSessionSettings 
     private static final boolean DEBUG = false;
 
     // This needs to match nsIDocShell.idl
     public static final int DISPLAY_MODE_BROWSER = 0;
     public static final int DISPLAY_MODE_MINIMAL_UI = 1;
     public static final int DISPLAY_MODE_STANDALONE = 2;
     public static final int DISPLAY_MODE_FULLSCREEN = 3;
 
-    private static class Key<T> {
-        public final String name;
-        public final boolean initOnly;
-        public final Collection<T> values;
+    public static class Key<T> {
+        /* package */ final String name;
+        /* package */ final boolean initOnly;
+        /* package */ final Collection<T> values;
 
-        public Key(final String name) {
+        /* package */ Key(final String name) {
             this(name, /* initOnly */ false, /* values */ null);
         }
 
-        public Key(final String name, final boolean initOnly, final Collection<T> values) {
+        /* package */ Key(final String name, final boolean initOnly,
+                          final Collection<T> values) {
             this.name = name;
             this.initOnly = initOnly;
             this.values = values;
         }
     }
 
     /**
      * Key to set the chrome window URI, or null to use default URI.