Bug 107264 - Make prefs parser errors louder. r=glandium draft
authorNicholas Nethercote <nnethercote@mozilla.com>
Mon, 19 Feb 2018 16:32:34 +1100
changeset 756883 a5e20bb76cf3ae1cf2c4b48e2e386ef14798f8e6
parent 755962 2f9f219db59c3e1d421324699aac0a71eb1b58c8
child 756884 2c21e3179b7c7bc83a74629f94fa4aeebae6f534
push id99575
push usernnethercote@mozilla.com
push dateMon, 19 Feb 2018 05:58:17 +0000
reviewersglandium
bugs107264
milestone60.0a1
Bug 107264 - Make prefs parser errors louder. r=glandium MozReview-Commit-ID: Ah36kygP3ix
modules/libpref/Preferences.cpp
--- a/modules/libpref/Preferences.cpp
+++ b/modules/libpref/Preferences.cpp
@@ -1101,20 +1101,22 @@ private:
 
   static void HandleError(const char* aMsg)
   {
     nsresult rv;
     nsCOMPtr<nsIConsoleService> console =
       do_GetService("@mozilla.org/consoleservice;1", &rv);
     if (NS_SUCCEEDED(rv)) {
       console->LogStringMessage(NS_ConvertUTF8toUTF16(aMsg).get());
-    } else {
-      printf_stderr("%s\n", aMsg);
     }
-    NS_WARNING(aMsg);
+#ifdef DEBUG
+    NS_ERROR(aMsg);
+#else
+    printf_stderr("%s\n", aMsg);
+#endif
   }
 
   // This is static so that HandlePref() can increment it easily. This is ok
   // because prefs files are read one at a time.
   static uint32_t sNumPrefs;
 };
 
 uint32_t Parser::sNumPrefs = 0;