Bug 1439001 - AudioLevel RTP header ext. send/recv sense reversed in xceiver draft
authorNico Grunbaum
Fri, 16 Feb 2018 16:27:07 -0800
changeset 757593 0679175cf04db4a2d75baa7c8d7d2599cdc0dce9
parent 757244 2c000486eac466da6623e4d7f7f1fd4e318f60e8
push id99788
push userna-g@nostrum.com
push dateTue, 20 Feb 2018 21:32:35 +0000
bugs1439001
milestone60.0a1
Bug 1439001 - AudioLevel RTP header ext. send/recv sense reversed in xceiver MozReview-Commit-ID: CyI4Rh3juUe
media/webrtc/signaling/src/peerconnection/TransceiverImpl.cpp
--- a/media/webrtc/signaling/src/peerconnection/TransceiverImpl.cpp
+++ b/media/webrtc/signaling/src/peerconnection/TransceiverImpl.cpp
@@ -729,17 +729,17 @@ TransceiverImpl::UpdateAudioConduit()
     }
 
     const SdpExtmapAttributeList::Extmap* audioLevelExt =
         details.GetExt(webrtc::RtpExtension::kAudioLevelUri);
     if (audioLevelExt) {
       MOZ_MTLOG(ML_DEBUG, "Calling EnableAudioLevelExtension");
       error = conduit->EnableAudioLevelExtension(true,
                                                  audioLevelExt->entry,
-                                                 true);
+                                                 false);
 
       if (error) {
         MOZ_MTLOG(ML_ERROR, mPCHandle << "[" << mMid << "]: " << __FUNCTION__ <<
                             " EnableAudioLevelExtension failed: " << error);
         return NS_ERROR_FAILURE;
       }
     }
   }
@@ -776,17 +776,17 @@ TransceiverImpl::UpdateAudioConduit()
     // Should these be genericized like they are in the video conduit case?
     const SdpExtmapAttributeList::Extmap* audioLevelExt =
         details.GetExt(webrtc::RtpExtension::kAudioLevelUri);
 
     if (audioLevelExt) {
       MOZ_MTLOG(ML_DEBUG, "Calling EnableAudioLevelExtension");
       error = conduit->EnableAudioLevelExtension(true,
                                                  audioLevelExt->entry,
-                                                 false);
+                                                 true);
 
       if (error) {
         MOZ_MTLOG(ML_ERROR, mPCHandle << "[" << mMid << "]: " << __FUNCTION__ <<
                             " EnableAudioLevelExtension failed: " << error);
         return NS_ERROR_FAILURE;
       }
     }