Bug 1438332 - Change RCWN test to expect the to account for very fast code execution r=michal draft
authorValentin Gosu <valentin.gosu@gmail.com>
Sat, 17 Feb 2018 00:25:51 +0100
changeset 756425 5e123337f73e6b95f5f0afa7d63604d5558dfd94
parent 755833 994a8d6eccbcdc6106794705bd77e3ac5f031be2
push id99485
push uservalentin.gosu@gmail.com
push dateFri, 16 Feb 2018 23:26:13 +0000
reviewersmichal
bugs1438332
milestone60.0a1
Bug 1438332 - Change RCWN test to expect the to account for very fast code execution r=michal The test would set a timer for 200ms then expect to be called back more than 200ms later (as in 201ms or more) This change makes sure that we don't fail if the callback comes back exactly 200ms later. MozReview-Commit-ID: 1OCyO3juAdZ
netwerk/test/unit/test_race_cache_with_network.js
--- a/netwerk/test/unit/test_race_cache_with_network.js
+++ b/netwerk/test/unit/test_race_cache_with_network.js
@@ -112,17 +112,17 @@ function *testSteps() {
   equal(g304Counter, 1, "check number of 304 responses");
 
   // Checks that delaying the response from the cache works.
   var channel = make_channel("http://localhost:" + PORT + "/rcwn");
   channel.QueryInterface(Components.interfaces.nsIRaceCacheWithNetwork).test_delayCacheEntryOpeningBy(200);
   let startTime = Date.now();
   channel.asyncOpen2(new ChannelListener(checkContent, null));
   yield undefined;
-  greater(Date.now() - startTime, 200, "Check that timer works properly");
+  greaterOrEqual(Date.now() - startTime, 200, "Check that timer works properly");
   equal(gResponseCounter, 3);
   equal(g200Counter, 1, "check number of 200 responses");
   equal(g304Counter, 2, "check number of 304 responses");
 
   // Checks that we can trigger the cache open immediately, even if the cache delay is set very high.
   var channel = make_channel("http://localhost:" + PORT + "/rcwn");
   channel.QueryInterface(Components.interfaces.nsIRaceCacheWithNetwork).test_delayCacheEntryOpeningBy(100000);
   channel.asyncOpen2(new ChannelListener(checkContent, null));