Bug 1437811 - Part 1 - Fix test that didn't wait for PanelMultiView events. r=Gijs draft
authorPaolo Amadini <paolo.mozmail@amadzone.org>
Wed, 14 Feb 2018 14:12:57 +0000
changeset 755556 85191989c5b6925c4659c5afd8f7647e6950b49f
parent 755533 9b69cc60e5848f2f8802c911fd00771b50eed41f
child 755557 5ec65cf52fcae903c7faddc01c486abf9315d6d3
push id99192
push userpaolo.mozmail@amadzone.org
push dateThu, 15 Feb 2018 13:35:45 +0000
reviewersGijs
bugs1437811
milestone60.0a1
Bug 1437811 - Part 1 - Fix test that didn't wait for PanelMultiView events. r=Gijs MozReview-Commit-ID: CxWMEkzGMyZ
browser/modules/test/browser/browser_BrowserUITelemetry_syncedtabs.js
--- a/browser/modules/test/browser/browser_BrowserUITelemetry_syncedtabs.js
+++ b/browser/modules/test/browser/browser_BrowserUITelemetry_syncedtabs.js
@@ -64,24 +64,29 @@ add_task(async function test_menu() {
   // Reset BrowserUITelemetry's world.
   BUIT._countableEvents = {};
 
   let tabsUpdated = promiseTabsUpdated();
 
   // check the button's functionality
   CustomizableUI.addWidgetToArea("sync-button", "nav-bar");
 
+  let remoteTabsView = document.getElementById("PanelUI-remotetabs");
+  let viewShown = BrowserTestUtils.waitForEvent(remoteTabsView, "ViewShown");
   let syncButton = document.getElementById("sync-button");
   syncButton.click();
+  await viewShown;
 
   await tabsUpdated;
   // Get our 1 tab and click on it.
+  let viewHidden = BrowserTestUtils.waitForEvent(remoteTabsView, "ViewHiding");
   let tabList = document.getElementById("PanelUI-remotetabs-tabslist");
   let tabEntry = tabList.firstChild.nextSibling;
   tabEntry.click();
+  await viewHidden;
 
   let counts = BUIT._countableEvents[BUIT.currentBucket];
   Assert.deepEqual(counts, {
     "click-builtin-item": { "sync-button": { left: 1 } },
     "synced-tabs": { open: { "toolbarbutton-subview": 1 } },
   });
   CustomizableUI.reset();
 });