Bug 1438174 - Fix race during test shutdown in browser_browser_toolbox_debugger.js. r=jryans draft
authorAlexandre Poirot <poirot.alex@gmail.com>
Wed, 14 Feb 2018 09:55:58 -0800
changeset 755632 4ce28c80ecb8312bf5b9038a4d5ef3b1038ee8d9
parent 755532 026401920e32e641eb42b068a16d7dd9e86c66a4
child 755634 72feb314698dbe56366b3dddd1505bae531e53d8
push id99222
push userbmo:poirot.alex@gmail.com
push dateThu, 15 Feb 2018 16:05:48 +0000
reviewersjryans
bugs1438174
milestone60.0a1
Bug 1438174 - Fix race during test shutdown in browser_browser_toolbox_debugger.js. r=jryans The breakpoint is set in a function called every second. We have to unregister it before test finishes, otherwise it gets randomly called during test shutdown. MozReview-Commit-ID: IEHxnVjk1xW
devtools/client/framework/test/test_browser_toolbox_debugger.js
--- a/devtools/client/framework/test/test_browser_toolbox_debugger.js
+++ b/devtools/client/framework/test/test_browser_toolbox_debugger.js
@@ -36,13 +36,18 @@ Task.spawn(function* () {
   yield onPaused;
 
   assertPausedLocation(dbg, "browser-toolbox-test.js", 2);
 
   yield stepIn(dbg);
 
   assertPausedLocation(dbg, "browser-toolbox-test.js", 3);
 
+  // Remove the breakpoint before resuming in order to prevent hitting the breakpoint
+  // again during test closing.
+  let source = findSource(dbg, "browser-toolbox-test.js");
+  yield removeBreakpoint(dbg, source.id, 2);
+
   yield resume(dbg);
 
   info("Close the browser toolbox");
   toolbox.destroy();
 });