Bug 1438106 - Fix a resource leak on fd r?Alex_Gaynor
MozReview-Commit-ID: JJliNhMpzct
--- a/toolkit/crashreporter/nsExceptionHandler.cpp
+++ b/toolkit/crashreporter/nsExceptionHandler.cpp
@@ -3126,19 +3126,21 @@ WriteExtraForMinidump(nsIFile* minidump,
#else
fd = fdopen(PR_FileDesc2NativeHandle(prFd), "r");
#endif
if (fd) {
AnnotationTable exceptionTimeAnnotations;
ReadAndValidateExceptionTimeAnnotations(fd, exceptionTimeAnnotations);
PR_Close(prFd);
if (!AppendExtraData(extra, exceptionTimeAnnotations)) {
+ fclose(fd);
return false;
}
}
+ fclose(fd);
}
extra.forget(extraFile);
return true;
}
// It really only makes sense to call this function when