Bug 1438106 - Fix a resource leak on fd r?Alex_Gaynor draft
authorSylvestre Ledru <sledru@mozilla.com>
Wed, 14 Feb 2018 09:35:55 +0100
changeset 754777 6f712dd8bc082f19cd9bed95ada8a4f0d9e54511
parent 754529 f1e39e547b29ee6eb323ff5fe18c5084791c8da1
push id98994
push usersledru@mozilla.com
push dateWed, 14 Feb 2018 08:36:42 +0000
reviewersAlex_Gaynor
bugs1438106
milestone60.0a1
Bug 1438106 - Fix a resource leak on fd r?Alex_Gaynor MozReview-Commit-ID: JJliNhMpzct
toolkit/crashreporter/nsExceptionHandler.cpp
--- a/toolkit/crashreporter/nsExceptionHandler.cpp
+++ b/toolkit/crashreporter/nsExceptionHandler.cpp
@@ -3126,19 +3126,21 @@ WriteExtraForMinidump(nsIFile* minidump,
 #else
     fd = fdopen(PR_FileDesc2NativeHandle(prFd), "r");
 #endif
     if (fd) {
       AnnotationTable exceptionTimeAnnotations;
       ReadAndValidateExceptionTimeAnnotations(fd, exceptionTimeAnnotations);
       PR_Close(prFd);
       if (!AppendExtraData(extra, exceptionTimeAnnotations)) {
+        fclose(fd);
         return false;
       }
     }
+    fclose(fd);
   }
 
   extra.forget(extraFile);
 
   return true;
 }
 
 // It really only makes sense to call this function when