Bug 1437856 - Enable new frontend in browser console in new console test folder; r=miker. draft
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Tue, 13 Feb 2018 14:41:44 +0100
changeset 754456 71c4df1bc44a138b4cae3b96cc8bdef469686b2c
parent 754423 48fa0529864f51ce93d8d0dc10b4859ba41719c2
child 754458 52e6deffbaf0277f941b23f02bdff2660299bae1
push id98877
push userbmo:nchevobbe@mozilla.com
push dateTue, 13 Feb 2018 15:56:09 +0000
reviewersmiker
bugs1437856
milestone60.0a1
Bug 1437856 - Enable new frontend in browser console in new console test folder; r=miker. We take this as an advantage to change the bug number for the browser_console test migration. MozReview-Commit-ID: 2EbvXJ6Qz08
devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
devtools/client/webconsole/new-console-output/test/mochitest/head.js
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
@@ -161,41 +161,41 @@ support-files =
   testscript.js
   !/devtools/client/netmonitor/test/sjs_cors-test-server.sjs
   !/image/test/mochitest/blue.png
   !/devtools/client/framework/test/shared-head.js
   !/devtools/client/shared/test/test-actor.js
   !/devtools/client/shared/test/test-actor-registry.js
 
 [browser_console.js]
-skip-if = true # Bug 1406060
+skip-if = true # Bug 1437806
 [browser_console_addonsdk_loader_exception.js]
-skip-if = true # Bug 1406060
+skip-if = true # Bug 1437807
 [browser_console_clear_method.js]
-skip-if = true # Bug 1406060
+skip-if = true # Bug 1437843
 [browser_console_consolejsm_output.js]
-skip-if = true # Bug 1406060
+skip-if = true # Bug 1437844
 [browser_console_dead_objects.js]
-skip-if = true # Bug 1406060
+skip-if = true # Bug 1437845
 [browser_console_error_source_click.js]
-skip-if = true # Bug 1406060
+skip-if = true # Bug 1437847
 [browser_console_filters.js]
-skip-if = true # Bug 1406060
+skip-if = true # Bug 1437848
 [browser_console_hide_jsterm_when_devtools_chrome_enabled_false.js]
-skip-if = true # Bug 1406060
+skip-if = true # Bug 1437849
 [browser_console_nsiconsolemessage.js]
-skip-if = true # Bug 1406060
+skip-if = true # Bug 1437850
 [browser_console_open_or_focus.js]
-skip-if = true # Bug 1406060
+skip-if = true # Bug 1437851
 [browser_console_restore.js]
-skip-if = true # Bug 1406060
+skip-if = true # Bug 1437852
 [browser_console_webconsole_ctrlw_close_tab.js]
-skip-if = true # Bug 1406060
+skip-if = true # Bug 1437854
 [browser_console_webconsole_iframe_messages.js]
-skip-if = true # Bug 1406060
+skip-if = true # Bug 1437855
 [browser_console_webconsole_private_browsing.js]
 skip-if = true #	Bug 1403188
 # old console skip-if = e10s # Bug 1042253 - webconsole e10s tests
 [browser_jsterm_accessibility.js]
 [browser_jsterm_add_edited_input_to_history.js]
 [browser_jsterm_autocomplete_array_no_index.js]
 [browser_jsterm_autocomplete_cached_results.js]
 [browser_jsterm_autocomplete_crossdomain_iframe.js]
--- a/devtools/client/webconsole/new-console-output/test/mochitest/head.js
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/head.js
@@ -26,33 +26,33 @@ const DOCS_GA_PARAMS = `?${new URLSearch
   "utm_campaign": "default"
 })}`;
 const STATUS_CODES_GA_PARAMS = `?${new URLSearchParams({
   "utm_source": "mozilla",
   "utm_medium": "devtools-webconsole",
   "utm_campaign": "default"
 })}`;
 
-Services.prefs.setBoolPref("devtools.webconsole.new-frontend-enabled", true);
-registerCleanupFunction(function* () {
-  Services.prefs.clearUserPref("devtools.webconsole.new-frontend-enabled");
+Services.prefs.setBoolPref("devtools.browserconsole.new-frontend-enabled", true);
+registerCleanupFunction(async function () {
+  Services.prefs.clearUserPref("devtools.browserconsole.new-frontend-enabled");
   Services.prefs.clearUserPref("devtools.webconsole.ui.filterbar");
 
   // Reset all filter prefs between tests. First flushPrefEnv in case one of the
   // filter prefs has been pushed for the test
-  yield SpecialPowers.flushPrefEnv();
+  await SpecialPowers.flushPrefEnv();
   Services.prefs.getChildList("devtools.webconsole.filter").forEach(pref => {
     Services.prefs.clearUserPref(pref);
   });
   let browserConsole = HUDService.getBrowserConsole();
   if (browserConsole) {
     if (browserConsole.jsterm) {
       browserConsole.jsterm.clearOutput(true);
     }
-    yield HUDService.toggleBrowserConsole();
+    await HUDService.toggleBrowserConsole();
   }
 });
 
 /**
  * Add a new tab and open the toolbox in it, and select the webconsole.
  *
  * @param string url
  *        The URL for the tab to be opened.