Bug 1436690 - Fix React 16 warning in NetworkMessage component; r=bgrins. draft
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Mon, 12 Feb 2018 16:17:00 +0100
changeset 754485 9b585b7a0dfb251b80d7712ed8dd18169a474199
parent 754484 e885564f81c9396ef12205dfdd10d09a7f5e13bc
child 754486 865a59b3dfbc6f8ec59a1bd7dfcd3683a0b3a8b7
push id98898
push userbmo:nchevobbe@mozilla.com
push dateTue, 13 Feb 2018 17:53:55 +0000
reviewersbgrins
bugs1436690
milestone60.0a1
Bug 1436690 - Fix React 16 warning in NetworkMessage component; r=bgrins. In this component we had an <a> element as a child of another <a> element, which isn't valid. Furthermore, we didn't make use of this <a>, so switching to a span brings us validity without any drawbacks. MozReview-Commit-ID: 3EM8jkEtSKI
devtools/client/webconsole/new-console-output/components/message-types/NetworkEventMessage.js
--- a/devtools/client/webconsole/new-console-output/components/message-types/NetworkEventMessage.js
+++ b/devtools/client/webconsole/new-console-output/components/message-types/NetworkEventMessage.js
@@ -72,17 +72,17 @@ function NetworkEventMessage({
     statusText,
   } = response;
 
   const topLevelClasses = [ "cm-s-mozilla" ];
   let statusCode, statusInfo;
 
   if (httpVersion && status && statusText !== undefined && totalTime !== undefined) {
     let statusCodeDocURL = getHTTPStatusCodeURL(status.toString(), "webconsole");
-    statusCode = dom.a({
+    statusCode = dom.span({
       className: "status-code",
       "data-code": status,
       title: LEARN_MORE,
       onClick: (e) => {
         e.stopPropagation();
         e.preventDefault();
         serviceContainer.openLink(statusCodeDocURL, e);
       }