Bug 1437431 - Give the Rich autocomplete panel a proper role to override the default popup XBL binding of menupopup, r?paolo draft
authorMarco Zehe <mzehe@mozilla.com>
Mon, 12 Feb 2018 14:59:18 +0100
changeset 753857 38ed39357e0c37e8e84c10304667b8c250a0faa8
parent 753837 87ba2465c82e5b354d8f4aafe37deba610cf192b
push id98700
push usermzehe@mozilla.com
push dateMon, 12 Feb 2018 15:39:22 +0000
reviewerspaolo
bugs1437431
milestone60.0a1
Bug 1437431 - Give the Rich autocomplete panel a proper role to override the default popup XBL binding of menupopup, r?paolo Screen readers, especially on Windows, react very sensitively to a menu and expect certain children. Some, for example, only accept menu items, menu checkboxes or menu radio items, but no full-blown widgets like a rich listbox. So, this patch changes the role for the panels that pop up with search results or auto complete entries, to be like a normal grouping panel. MozReview-Commit-ID: GCVXAPttV1M
browser/base/content/browser.xul
--- a/browser/base/content/browser.xul
+++ b/browser/base/content/browser.xul
@@ -131,31 +131,34 @@
                onclick="checkForMiddleClick(this, event);"/>
     <tooltip id="aHTMLTooltip" page="true"/>
     <tooltip id="remoteBrowserTooltip"/>
 
     <!-- for search and content formfill/pw manager -->
 
     <panel type="autocomplete-richlistbox"
            id="PopupAutoComplete"
+           role="group"
            noautofocus="true"
            hidden="true"
            overflowpadding="4"
            norolluponanchor="true"
            nomaxresults="true" />
 
     <!-- for search with one-off buttons -->
     <panel type="autocomplete-richlistbox"
            id="PopupSearchAutoComplete"
+           role="group"
            noautofocus="true"
            hidden="true" />
 
     <!-- for url bar autocomplete -->
     <panel type="autocomplete-richlistbox"
            id="PopupAutoCompleteRichResult"
+           role="group"
            noautofocus="true"
            hidden="true"
            flip="none"
            level="parent"
            overflowpadding="15" />
 
    <!-- for date/time picker. consumeoutsideclicks is set to never, so that
         clicks on the anchored input box are never consumed. -->