Bug 1418605 - Rename --url-and-searchbar-background-color and --url-and-searchbar-color for clarity as they are used elsewhere r?jaws,mconley,ntim,dao draft
authorBogdan Pozderca <bogdan@pozderca.com>
Sun, 11 Feb 2018 13:18:06 -0500
changeset 755307 f5e313c233648b82eafbccfe9a5bc2a73c6aa1d0
parent 755306 8763890cfb5b6c7967a0a2640f69acbfee3a5621
push id99147
push userbogdan@pozderca.com
push dateThu, 15 Feb 2018 05:26:06 +0000
reviewersjaws, mconley, ntim, dao
bugs1418605
milestone60.0a1
Bug 1418605 - Rename --url-and-searchbar-background-color and --url-and-searchbar-color for clarity as they are used elsewhere r?jaws,mconley,ntim,dao MozReview-Commit-ID: 1qd4URABht1
browser/themes/shared/compacttheme.inc.css
browser/themes/shared/urlbar-searchbar.inc.css
toolkit/modules/LightweightThemeConsumer.jsm
toolkit/themes/linux/global/findBar.css
toolkit/themes/osx/global/findBar.css
toolkit/themes/windows/global/findBar.css
--- a/browser/themes/shared/compacttheme.inc.css
+++ b/browser/themes/shared/compacttheme.inc.css
@@ -27,23 +27,23 @@
   --chrome-nav-bar-separator-color: rgba(0,0,0,.2);
   --chrome-nav-buttons-background: hsla(240, 5%, 5%, .1);
   --chrome-nav-buttons-hover-background: hsla(240, 5%, 5%, .15);
   --chrome-nav-bar-controls-border-color: hsla(240, 5%, 5%, .3);
   --chrome-selection-color: #fff;
   --chrome-selection-background-color: #5675B9;
 
   /* Url and search bars */
-  --url-and-searchbar-background-color: rgb(71, 71, 73);
-  --url-and-searchbar-color: var(--chrome-color);
+  --lwt-toolbar-field-background-color: rgb(71, 71, 73);
+  --lwt-toolbar-field-color: var(--chrome-color);
   --urlbar-separator-color: #5F6670;
 }
 
 :root:-moz-lwtheme-darktext {
-  --url-and-searchbar-background-color: #fff;
+  --lwt-toolbar-field-background-color: #fff;
 
   --chrome-background-color: #E3E4E6;
   --chrome-color: #18191a;
   --chrome-secondary-background-color: #f5f6f7;
   --toolbox-border-bottom-color: #cccccc;
   --chrome-nav-bar-separator-color: #B6B6B8;
   --chrome-nav-buttons-background: #ffffff; /* --theme-body-background */
   --chrome-nav-buttons-hover-background: #DADBDB;
@@ -109,9 +109,8 @@ toolbar[brighttext] .toolbarbutton-1 {
 #urlbar-zoom-button:-moz-lwtheme-brighttext:hover:active {
   background-color: rgba(255,255,255,.3);
 }
 
 .tab-icon-sound[soundplaying],
 .tab-icon-sound[muted] {
   filter: none !important; /* removes drop-shadow filter */
 }
-
--- a/browser/themes/shared/urlbar-searchbar.inc.css
+++ b/browser/themes/shared/urlbar-searchbar.inc.css
@@ -39,35 +39,35 @@
 #urlbar:hover,
 .searchbar-textbox:hover {
   border-color: @fieldHoverBorderColor@;
   box-shadow: 0 1px 6px rgba(0,0,0,.1);
 }
 
 #urlbar:-moz-lwtheme,
 #navigator-toolbox .searchbar-textbox:-moz-lwtheme {
-  background-color: var(--url-and-searchbar-background-color, hsla(0,0%,100%,.8));
-  color: var(--url-and-searchbar-color, black);
+  background-color: var(--lwt-toolbar-field-background-color, hsla(0,0%,100%,.8));
+  color: var(--lwt-toolbar-field-color, black);
 }
 
 #urlbar:not([focused="true"]):-moz-lwtheme,
 #navigator-toolbox .searchbar-textbox:not([focused="true"]):-moz-lwtheme {
   border-color: var(--lwt-toolbar-field-border-color, @fieldBorderColor@);
 }
 
 #urlbar:not([focused="true"]):-moz-lwtheme:hover,
 #navigator-toolbox .searchbar-textbox:not([focused="true"]):-moz-lwtheme:hover {
   border-color: var(--lwt-toolbar-field-border-color, @fieldHoverBorderColor@);
 }
 
 #urlbar:-moz-lwtheme:hover,
 #urlbar:-moz-lwtheme[focused="true"],
 #navigator-toolbox .searchbar-textbox:-moz-lwtheme:hover,
 #navigator-toolbox .searchbar-textbox:-moz-lwtheme[focused="true"] {
-  background-color: var(--url-and-searchbar-background-color, white);
+  background-color: var(--lwt-toolbar-field-background-color, white);
 }
 
 :root[uidensity=compact] #urlbar,
 :root[uidensity=compact] .searchbar-textbox {
   min-height: 26px;
   margin-top: 3px;
   margin-bottom: 3px;
 }
--- a/toolkit/modules/LightweightThemeConsumer.jsm
+++ b/toolkit/modules/LightweightThemeConsumer.jsm
@@ -14,18 +14,18 @@ ChromeUtils.defineModuleGetter(this, "Li
 const kCSSVarsMap = [
   ["--lwt-accent-color-inactive", "accentcolorInactive"],
   ["--lwt-background-alignment", "backgroundsAlignment"],
   ["--lwt-background-tiling", "backgroundsTiling"],
   ["--tab-loading-fill", "tab_loading", "tabbrowser-tabs"],
   ["--lwt-tab-text", "tab_text"],
   ["--toolbar-bgcolor", "toolbarColor"],
   ["--toolbar-color", "toolbar_text"],
-  ["--url-and-searchbar-background-color", "toolbar_field"],
-  ["--url-and-searchbar-color", "toolbar_field_text"],
+  ["--lwt-toolbar-field-background-color", "toolbar_field"],
+  ["--lwt-toolbar-field-color", "toolbar_field_text"],
   ["--lwt-toolbar-field-border-color", "toolbar_field_border"],
   ["--urlbar-separator-color", "toolbar_field_separator"],
   ["--tabs-border-color", "toolbar_top_separator", "navigator-toolbox"],
   ["--lwt-toolbar-vertical-separator", "toolbar_vertical_separator"],
   ["--toolbox-border-bottom-color", "toolbar_bottom_separator"],
   ["--lwt-toolbarbutton-icon-fill", "icon_color"],
   ["--lwt-toolbarbutton-icon-fill-attention", "icon_attention_color"],
   ["--lwt-toolbarbutton-hover-background", "button_background_hover"],
--- a/toolkit/themes/linux/global/findBar.css
+++ b/toolkit/themes/linux/global/findBar.css
@@ -46,18 +46,18 @@ findbar[noanim] {
   box-shadow: 0 0 1px 0 ThreeDShadow inset;
   color: -moz-FieldText;
   margin: 0;
   padding: 5px;
   width: 14em;
 }
 
 .findbar-textbox:-moz-lwtheme {
-  background-color: var(--url-and-searchbar-background-color, -moz-Field);
-  color: var(--url-and-searchbar-color, -moz-FieldText);
+  background-color: var(--lwt-toolbar-field-background-color, -moz-Field);
+  color: var(--lwt-toolbar-field-color, -moz-FieldText);
 }
 
 .findbar-textbox:-moz-locale-dir(ltr) {
   border-radius: 3px 0 0 3px;
   border-right-width: 0;
 }
 
 .findbar-textbox:-moz-locale-dir(rtl) {
--- a/toolkit/themes/osx/global/findBar.css
+++ b/toolkit/themes/osx/global/findBar.css
@@ -148,18 +148,18 @@ label.findbar-find-fast:-moz-lwtheme,
   background-position: 5px center;
   color: -moz-FieldText;
   margin: 0;
   padding: 2px 8px;
   padding-inline-start: 19px;
 }
 
 .findbar-textbox:-moz-lwtheme {
-  background-color: var(--url-and-searchbar-background-color, -moz-Field);
-  color: var(--url-and-searchbar-color, -moz-FieldText);
+  background-color: var(--lwt-toolbar-field-background-color, -moz-Field);
+  color: var(--lwt-toolbar-field-color, -moz-FieldText);
 }
 
 .findbar-textbox:-moz-locale-dir(rtl) {
   border-radius: 0 10000px 10000px 0;
   background-position-x: calc(100% - 5px);
 }
 
 @media (-moz-mac-yosemite-theme) {
--- a/toolkit/themes/windows/global/findBar.css
+++ b/toolkit/themes/windows/global/findBar.css
@@ -53,18 +53,18 @@ findbar[noanim] {
   border-radius: 2px 0 0 2px;
   color: -moz-FieldText;
   margin: 0;
   padding: 1px 5px;
   width: 14em;
 }
 
 .findbar-textbox:-moz-lwtheme {
-  background-color: var(--url-and-searchbar-background-color, -moz-Field);
-  color: var(--url-and-searchbar-color, -moz-FieldText);
+  background-color: var(--lwt-toolbar-field-background-color, -moz-Field);
+  color: var(--lwt-toolbar-field-color, -moz-FieldText);
 }
 
 .findbar-textbox:-moz-locale-dir(rtl) {
   border-radius: 0 2px 2px 0;
 }
 
 .findbar-textbox[focused="true"] {
   border-color: Highlight;