Bug 1408121: Dark theme should apply dark colors to Firefox menus.r=ntim draft
authorConnor Masini <cjmasini@gmail.com>
Sat, 10 Feb 2018 14:48:09 -0500
changeset 766570 2415fc46287ee1df58097f940e6f01f519ea3c36
parent 759390 25fbbd9fb23c4ecd04d573036f2d65b5c86eb49c
child 768677 27550ac6640c1e8774e5a89adbd24b56957ff7bb
child 771502 fe3485f74e1f8e4b599a409e58e150b55b378202
child 771503 789ee51b575c7dd8c3941cacbe40893b241bebce
child 771646 d440ce454b27aa2c428e7ddb1823ba93b221d96b
child 771657 2e3c76a47d2ab3fd2f1ff4d381859779eb34f7b6
child 771723 7a4f028c87dc851c5a946d8bc6df2cbf83a6f7f2
child 775282 1deccb0fd3da3b258d042a5d5b01d8e85ddd46e4
child 775283 38f1fedb95a5b8bd0b2fa5e1c3dbacec678be5a9
child 775293 a64818dbc61470c13cf9f4288159b49618e5f8b2
child 778687 8cfd60d6382577d7aabda2b3f9d9cc1dc9ab4ec3
push id102356
push userbmo:masinico@msu.edu
push dateTue, 13 Mar 2018 00:56:19 +0000
reviewersntim
bugs1408121
milestone60.0a1
Bug 1408121: Dark theme should apply dark colors to Firefox menus.r=ntim MozReview-Commit-ID: 9aaPYZPiHf8
browser/components/nsBrowserGlue.js
--- a/browser/components/nsBrowserGlue.js
+++ b/browser/components/nsBrowserGlue.js
@@ -707,16 +707,19 @@ BrowserGlue.prototype = {
     });
     LightweightThemeManager.addBuiltInTheme({
       id: "firefox-compact-dark@mozilla.org",
       name: gBrowserBundle.GetStringFromName("darkTheme.name"),
       description: gBrowserBundle.GetStringFromName("darkTheme.description"),
       iconURL: "resource:///chrome/browser/content/browser/defaultthemes/dark.icon.svg",
       textcolor: "white",
       accentcolor: "black",
+      popup: "hsl(240, 5%, 5%)",
+      popup_text: "rgb(249, 249, 250)",
+      popup_border: "rgba(24, 26, 27, 0.14)",
       author: vendorShortName,
     });
 
 
     // Initialize the default l10n resource sources for L10nRegistry.
     const multilocalePath = "resource://gre/res/multilocale.json";
     L10nRegistry.bootstrap = fetch(multilocalePath).then(d => d.json()).then(({ locales }) => {
       const toolkitSource = new FileSource("toolkit", locales, "resource://gre/localization/{locale}/");