--- a/toolkit/components/places/nsNavBookmarks.cpp
+++ b/toolkit/components/places/nsNavBookmarks.cpp
@@ -158,17 +158,16 @@ NeedsTombstone(const BookmarkData& aBook
nsNavBookmarks::nsNavBookmarks()
: mRoot(0)
, mMenuRoot(0)
, mTagsRoot(0)
, mUnfiledRoot(0)
, mToolbarRoot(0)
, mMobileRoot(0)
, mCanNotify(false)
- , mCacheObservers("bookmark-observers")
, mBatching(false)
{
NS_ASSERTION(!gBookmarksService,
"Attempting to create two instances of the service!");
gBookmarksService = this;
}
@@ -623,17 +622,17 @@ nsNavBookmarks::InsertBookmark(int64_t a
if (grandParentId != tagsRootId) {
rv = history->UpdateFrecency(placeId);
NS_ENSURE_SUCCESS(rv, rv);
}
rv = transaction.Commit();
NS_ENSURE_SUCCESS(rv, rv);
- NOTIFY_BOOKMARKS_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
+ NOTIFY_BOOKMARKS_OBSERVERS(mCanNotify, mObservers,
SKIP_TAGS(grandParentId == mTagsRoot),
OnItemAdded(*aNewBookmarkId, aFolder, index,
TYPE_BOOKMARK, aURI, title, dateAdded,
guid, folderGuid, aSource));
// If the bookmark has been added to a tag container, notify all
// bookmark-folder result nodes which contain a bookmark for the new
// bookmark's url.
@@ -642,18 +641,17 @@ nsNavBookmarks::InsertBookmark(int64_t a
nsTArray<BookmarkData> bookmarks;
rv = GetBookmarksForURI(aURI, bookmarks);
NS_ENSURE_SUCCESS(rv, rv);
for (uint32_t i = 0; i < bookmarks.Length(); ++i) {
// Check that bookmarks doesn't include the current tag itemId.
MOZ_ASSERT(bookmarks[i].id != *aNewBookmarkId);
- NOTIFY_BOOKMARKS_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- DontSkip,
+ NOTIFY_BOOKMARKS_OBSERVERS(mCanNotify, mObservers, DontSkip,
OnItemChanged(bookmarks[i].id,
NS_LITERAL_CSTRING("tags"),
false,
EmptyCString(),
bookmarks[i].lastModified,
TYPE_BOOKMARK,
bookmarks[i].parentId,
bookmarks[i].guid,
@@ -753,17 +751,17 @@ nsNavBookmarks::RemoveItem(int64_t aItem
NS_ENSURE_SUCCESS(rv, rv);
}
// A broken url should not interrupt the removal process.
(void)NS_NewURI(getter_AddRefs(uri), bookmark.url);
// We cannot assert since some automated tests are checking this path.
NS_WARNING_ASSERTION(uri, "Invalid URI in RemoveItem");
}
- NOTIFY_BOOKMARKS_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
+ NOTIFY_BOOKMARKS_OBSERVERS(mCanNotify, mObservers,
SKIP_TAGS(bookmark.parentId == tagsRootId ||
bookmark.grandParentId == tagsRootId),
OnItemRemoved(bookmark.id,
bookmark.parentId,
bookmark.position,
bookmark.type,
uri,
bookmark.guid,
@@ -774,18 +772,17 @@ nsNavBookmarks::RemoveItem(int64_t aItem
uri) {
// If the removed bookmark was child of a tag container, notify a tags
// change to all bookmarks for this URI.
nsTArray<BookmarkData> bookmarks;
rv = GetBookmarksForURI(uri, bookmarks);
NS_ENSURE_SUCCESS(rv, rv);
for (uint32_t i = 0; i < bookmarks.Length(); ++i) {
- NOTIFY_BOOKMARKS_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- DontSkip,
+ NOTIFY_BOOKMARKS_OBSERVERS(mCanNotify, mObservers, DontSkip,
OnItemChanged(bookmarks[i].id,
NS_LITERAL_CSTRING("tags"),
false,
EmptyCString(),
bookmarks[i].lastModified,
TYPE_BOOKMARK,
bookmarks[i].parentId,
bookmarks[i].guid,
@@ -876,17 +873,17 @@ nsNavBookmarks::CreateContainerWithID(in
nullptr, aSource, aNewFolder, guid);
NS_ENSURE_SUCCESS(rv, rv);
rv = transaction.Commit();
NS_ENSURE_SUCCESS(rv, rv);
int64_t tagsRootId = TagsRootId();
- NOTIFY_BOOKMARKS_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
+ NOTIFY_BOOKMARKS_OBSERVERS(mCanNotify, mObservers,
SKIP_TAGS(aParent == tagsRootId),
OnItemAdded(*aNewFolder, aParent, index, FOLDER,
nullptr, title, dateAdded, guid,
folderGuid, aSource));
*aIndex = index;
return NS_OK;
}
@@ -932,18 +929,17 @@ nsNavBookmarks::InsertSeparator(int64_t
rv = InsertBookmarkInDB(-1, SEPARATOR, aParent, index, EmptyCString(), dateAdded,
0, folderGuid, grandParentId, nullptr, aSource,
aNewItemId, guid);
NS_ENSURE_SUCCESS(rv, rv);
rv = transaction.Commit();
NS_ENSURE_SUCCESS(rv, rv);
- NOTIFY_BOOKMARKS_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- DontSkip,
+ NOTIFY_BOOKMARKS_OBSERVERS(mCanNotify, mObservers, DontSkip,
OnItemAdded(*aNewItemId, aParent, index, TYPE_SEPARATOR,
nullptr, EmptyCString(), dateAdded, guid,
folderGuid, aSource));
return NS_OK;
}
@@ -1206,17 +1202,17 @@ nsNavBookmarks::RemoveFolderChildren(int
NS_ENSURE_SUCCESS(rv, rv);
}
// A broken url should not interrupt the removal process.
(void)NS_NewURI(getter_AddRefs(uri), child.url);
// We cannot assert since some automated tests are checking this path.
NS_WARNING_ASSERTION(uri, "Invalid URI in RemoveFolderChildren");
}
- NOTIFY_BOOKMARKS_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
+ NOTIFY_BOOKMARKS_OBSERVERS(mCanNotify, mObservers,
((child.grandParentId == tagsRootId) ? SkipTags : SkipDescendants),
OnItemRemoved(child.id,
child.parentId,
child.position,
child.type,
uri,
child.guid,
child.parentGuid,
@@ -1227,18 +1223,17 @@ nsNavBookmarks::RemoveFolderChildren(int
// If the removed bookmark was a child of a tag container, notify all
// bookmark-folder result nodes which contain a bookmark for the removed
// bookmark's url.
nsTArray<BookmarkData> bookmarks;
rv = GetBookmarksForURI(uri, bookmarks);
NS_ENSURE_SUCCESS(rv, rv);
for (uint32_t i = 0; i < bookmarks.Length(); ++i) {
- NOTIFY_BOOKMARKS_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- DontSkip,
+ NOTIFY_BOOKMARKS_OBSERVERS(mCanNotify, mObservers, DontSkip,
OnItemChanged(bookmarks[i].id,
NS_LITERAL_CSTRING("tags"),
false,
EmptyCString(),
bookmarks[i].lastModified,
TYPE_BOOKMARK,
bookmarks[i].parentId,
bookmarks[i].guid,
@@ -1413,18 +1408,17 @@ nsNavBookmarks::MoveItem(int64_t aItemId
}
rv = PreventSyncReparenting(bookmark);
NS_ENSURE_SUCCESS(rv, rv);
rv = transaction.Commit();
NS_ENSURE_SUCCESS(rv, rv);
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavBookmarkObserver,
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavBookmarkObserver,
OnItemMoved(bookmark.id,
bookmark.parentId,
bookmark.position,
aNewParent,
newIndex,
bookmark.type,
bookmark.guid,
bookmark.parentGuid,
@@ -1582,18 +1576,17 @@ nsNavBookmarks::SetItemDateAdded(int64_t
NS_ENSURE_SUCCESS(rv, rv);
} else {
rv = SetItemDateInternal(DATE_ADDED, syncChangeDelta, bookmark.id,
bookmark.dateAdded);
NS_ENSURE_SUCCESS(rv, rv);
}
// Note: mDBSetItemDateAdded also sets lastModified to aDateAdded.
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavBookmarkObserver,
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavBookmarkObserver,
OnItemChanged(bookmark.id,
NS_LITERAL_CSTRING("dateAdded"),
false,
nsPrintfCString("%" PRId64, bookmark.dateAdded),
bookmark.dateAdded,
bookmark.type,
bookmark.parentId,
bookmark.guid,
@@ -1653,18 +1646,17 @@ nsNavBookmarks::SetItemLastModified(int6
NS_ENSURE_SUCCESS(rv, rv);
} else {
rv = SetItemDateInternal(LAST_MODIFIED, syncChangeDelta, bookmark.id,
bookmark.lastModified);
NS_ENSURE_SUCCESS(rv, rv);
}
// Note: mDBSetItemDateAdded also sets lastModified to aDateAdded.
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavBookmarkObserver,
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavBookmarkObserver,
OnItemChanged(bookmark.id,
NS_LITERAL_CSTRING("lastModified"),
false,
nsPrintfCString("%" PRId64, bookmark.lastModified),
bookmark.lastModified,
bookmark.type,
bookmark.parentId,
bookmark.guid,
@@ -1905,18 +1897,17 @@ nsNavBookmarks::SetItemTitle(int64_t aIt
rv = transaction.Commit();
NS_ENSURE_SUCCESS(rv, rv);
} else {
rv = SetItemTitleInternal(bookmark, title, syncChangeDelta);
NS_ENSURE_SUCCESS(rv, rv);
}
- NOTIFY_BOOKMARKS_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- SKIP_TAGS(isChangingTagFolder),
+ NOTIFY_BOOKMARKS_OBSERVERS(mCanNotify, mObservers, SKIP_TAGS(isChangingTagFolder),
OnItemChanged(bookmark.id,
NS_LITERAL_CSTRING("title"),
false,
title,
bookmark.lastModified,
bookmark.type,
bookmark.parentId,
bookmark.guid,
@@ -2452,18 +2443,17 @@ nsNavBookmarks::SetKeywordForBookmark(in
rv = stmt->Execute();
NS_ENSURE_SUCCESS(rv, rv);
}
rv = removeTxn.Commit();
NS_ENSURE_SUCCESS(rv, rv);
for (uint32_t i = 0; i < bookmarks.Length(); ++i) {
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavBookmarkObserver,
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavBookmarkObserver,
OnItemChanged(bookmarks[i].id,
NS_LITERAL_CSTRING("keyword"),
false,
EmptyCString(),
bookmarks[i].lastModified,
TYPE_BOOKMARK,
bookmarks[i].parentId,
bookmarks[i].guid,
@@ -2509,18 +2499,17 @@ nsNavBookmarks::SetKeywordForBookmark(in
nsCOMPtr<mozIStorageStatement> stmt;
if (oldUri) {
// In both cases, notify about the change.
nsTArray<BookmarkData> bookmarks;
rv = GetBookmarksForURI(oldUri, bookmarks);
NS_ENSURE_SUCCESS(rv, rv);
for (uint32_t i = 0; i < bookmarks.Length(); ++i) {
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavBookmarkObserver,
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavBookmarkObserver,
OnItemChanged(bookmarks[i].id,
NS_LITERAL_CSTRING("keyword"),
false,
EmptyCString(),
bookmarks[i].lastModified,
TYPE_BOOKMARK,
bookmarks[i].parentId,
bookmarks[i].guid,
@@ -2580,18 +2569,17 @@ nsNavBookmarks::SetKeywordForBookmark(in
NS_ENSURE_SUCCESS(rv, rv);
}
rv = updateTxn.Commit();
NS_ENSURE_SUCCESS(rv, rv);
// In both cases, notify about the change.
for (uint32_t i = 0; i < bookmarks.Length(); ++i) {
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavBookmarkObserver,
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavBookmarkObserver,
OnItemChanged(bookmarks[i].id,
NS_LITERAL_CSTRING("keyword"),
false,
NS_ConvertUTF16toUTF8(keyword),
bookmarks[i].lastModified,
TYPE_BOOKMARK,
bookmarks[i].parentId,
bookmarks[i].guid,
@@ -2693,20 +2681,16 @@ nsNavBookmarks::GetObservers(uint32_t* _
*_count = 0;
*_observers = nullptr;
if (!mCanNotify)
return NS_OK;
nsCOMArray<nsINavBookmarkObserver> observers;
- // First add the category cache observers.
- mCacheObservers.GetEntries(observers);
-
- // Then add the other observers.
for (uint32_t i = 0; i < mObservers.Length(); ++i) {
const nsCOMPtr<nsINavBookmarkObserver> &observer = mObservers.ElementAt(i).GetValue();
// Skip nullified weak observers.
if (observer)
observers.AppendElement(observer);
}
if (observers.Count() == 0)
@@ -2722,18 +2706,17 @@ void
nsNavBookmarks::NotifyItemVisited(const ItemVisitData& aData)
{
nsCOMPtr<nsIURI> uri;
MOZ_ALWAYS_SUCCEEDS(NS_NewURI(getter_AddRefs(uri), aData.bookmark.url));
// Notify the visit only if we have a valid uri, otherwise the observer
// couldn't gather enough data from the notification.
// This should be false only if there's a bug in the code preceding us.
if (uri) {
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavBookmarkObserver,
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavBookmarkObserver,
OnItemVisited(aData.bookmark.id,
aData.visitId,
aData.time,
aData.transitionType,
uri,
aData.bookmark.parentId,
aData.bookmark.guid,
aData.bookmark.parentGuid));
@@ -2749,18 +2732,17 @@ nsNavBookmarks::NotifyItemChanged(const
PRTime lastModified = aData.bookmark.lastModified;
if (aData.updateLastModified) {
lastModified = RoundedPRNow();
MOZ_ALWAYS_SUCCEEDS(SetItemDateInternal(
LAST_MODIFIED, DetermineSyncChangeDelta(aData.source),
aData.bookmark.id, lastModified));
}
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavBookmarkObserver,
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavBookmarkObserver,
OnItemChanged(aData.bookmark.id,
aData.property,
aData.isAnnotation,
aData.newValue,
lastModified,
aData.bookmark.type,
aData.bookmark.parentId,
aData.bookmark.guid,
@@ -2789,30 +2771,30 @@ nsNavBookmarks::Observe(nsISupports *aSu
}
////////////////////////////////////////////////////////////////////////////////
//// nsINavHistoryObserver
NS_IMETHODIMP
nsNavBookmarks::OnBeginUpdateBatch()
{
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
+ NOTIFY_OBSERVERS(mCanNotify, mObservers,
nsINavBookmarkObserver, OnBeginUpdateBatch());
return NS_OK;
}
NS_IMETHODIMP
nsNavBookmarks::OnEndUpdateBatch()
{
if (mBatching) {
mBatching = false;
}
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
+ NOTIFY_OBSERVERS(mCanNotify, mObservers,
nsINavBookmarkObserver, OnEndUpdateBatch());
return NS_OK;
}
NS_IMETHODIMP
nsNavBookmarks::OnVisits(nsIVisitData** aVisits, uint32_t aVisitsCount)
{
--- a/toolkit/components/places/nsNavHistory.cpp
+++ b/toolkit/components/places/nsNavHistory.cpp
@@ -281,17 +281,16 @@ nsNavHistory::nsNavHistory()
, mEmbedVisits(EMBED_VISITS_INITIAL_CACHE_LENGTH)
, mHistoryEnabled(true)
, mNumVisitsForFrecency(10)
, mTagsFolder(-1)
, mDaysOfHistory(-1)
, mLastCachedStartOfDay(INT64_MAX)
, mLastCachedEndOfDay(0)
, mCanNotify(true)
- , mCacheObservers("history-observers")
#ifdef XP_WIN
, mCryptoProviderInitialized(false)
#endif
{
NS_ASSERTION(!gHistoryService,
"Attempting to create two instances of the service!");
#ifdef XP_WIN
BOOL cryptoAcquired = CryptAcquireContext(&mCryptoProvider, 0, 0, PROV_RSA_FULL,
@@ -531,50 +530,47 @@ nsNavHistory::NotifyOnVisits(nsIVisitDat
for (uint32_t i = 0; i < aVisitsCount; ++i) {
PRTime time;
MOZ_ALWAYS_SUCCEEDS(aVisits[i]->GetTime(&time));
if (time > mLastCachedEndOfDay || time < mLastCachedStartOfDay) {
mDaysOfHistory = -1;
}
}
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavHistoryObserver,
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavHistoryObserver,
OnVisits(aVisits, aVisitsCount));
}
void
nsNavHistory::NotifyTitleChange(nsIURI* aURI,
const nsString& aTitle,
const nsACString& aGUID)
{
MOZ_ASSERT(!aGUID.IsEmpty());
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavHistoryObserver, OnTitleChanged(aURI, aTitle, aGUID));
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavHistoryObserver,
+ OnTitleChanged(aURI, aTitle, aGUID));
}
void
nsNavHistory::NotifyFrecencyChanged(nsIURI* aURI,
int32_t aNewFrecency,
const nsACString& aGUID,
bool aHidden,
PRTime aLastVisitDate)
{
MOZ_ASSERT(!aGUID.IsEmpty());
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavHistoryObserver,
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavHistoryObserver,
OnFrecencyChanged(aURI, aNewFrecency, aGUID, aHidden,
aLastVisitDate));
}
void
nsNavHistory::NotifyManyFrecenciesChanged()
{
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavHistoryObserver,
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavHistoryObserver,
OnManyFrecenciesChanged());
}
namespace {
class FrecencyNotification : public Runnable
{
public:
@@ -2374,19 +2370,16 @@ nsNavHistory::GetObservers(uint32_t* _co
// changes to history and is now trying to notify them.
mDaysOfHistory = -1;
if (!mCanNotify)
return NS_OK;
nsCOMArray<nsINavHistoryObserver> observers;
- // First add the category cache observers.
- mCacheObservers.GetEntries(observers);
-
// Then add the other observers.
for (uint32_t i = 0; i < mObservers.Length(); ++i) {
const nsCOMPtr<nsINavHistoryObserver> &observer = mObservers.ElementAt(i).GetValue();
// Skip nullified weak observers.
if (observer)
observers.AppendElement(observer);
}
@@ -2403,18 +2396,17 @@ nsNavHistory::GetObservers(uint32_t* _co
nsresult
nsNavHistory::BeginUpdateBatch()
{
if (mBatchLevel++ == 0) {
mBatchDBTransaction = new mozStorageTransaction(mDB->MainConn(), false,
mozIStorageConnection::TRANSACTION_DEFERRED,
true);
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavHistoryObserver, OnBeginUpdateBatch());
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavHistoryObserver, OnBeginUpdateBatch());
}
return NS_OK;
}
// nsNavHistory::EndUpdateBatch
nsresult
nsNavHistory::EndUpdateBatch()
{
@@ -2422,18 +2414,17 @@ nsNavHistory::EndUpdateBatch()
if (mBatchDBTransaction) {
DebugOnly<nsresult> rv = mBatchDBTransaction->Commit();
NS_WARNING_ASSERTION(NS_SUCCEEDED(rv),
"Batch failed to commit transaction");
delete mBatchDBTransaction;
mBatchDBTransaction = nullptr;
}
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavHistoryObserver, OnEndUpdateBatch());
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavHistoryObserver, OnEndUpdateBatch());
}
return NS_OK;
}
NS_IMETHODIMP
nsNavHistory::RunInBatchMode(nsINavHistoryBatchCallback* aCallback,
nsISupports* aUserData)
{
@@ -2551,18 +2542,17 @@ nsNavHistory::CleanupPlacesOnVisitsDelet
}
filteredPlaceIds.AppendInt(placeId);
URIs.AppendElement(uri.forget());
GUIDs.AppendElement(guid);
}
else {
// Notify that we will delete all visits for this page, but not the page
// itself, since it's bookmarked or a place: query.
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavHistoryObserver,
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavHistoryObserver,
OnDeleteVisits(uri, 0, guid, nsINavHistoryObserver::REASON_DELETED, 0));
}
}
// if the entry is not bookmarked and is not a place: uri
// then we can remove it from moz_places.
// Note that we do NOT delete favicons. Any unreferenced favicons will be
// deleted next time the browser is shut down.
@@ -2599,18 +2589,17 @@ nsNavHistory::CleanupPlacesOnVisitsDelet
NS_ENSURE_SUCCESS(rv, rv);
// Invalidate frecencies of touched places, since they need recalculation.
rv = invalidateFrecencies(aPlaceIdsQueryString);
NS_ENSURE_SUCCESS(rv, rv);
// Finally notify about the removed URIs.
for (int32_t i = 0; i < URIs.Count(); ++i) {
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavHistoryObserver,
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavHistoryObserver,
OnDeleteURI(URIs[i], GUIDs[i], nsINavHistoryObserver::REASON_DELETED));
}
return NS_OK;
}
// nsNavHistory::RemovePagesFromHost
@@ -2965,23 +2954,22 @@ nsNavHistory::NotifyOnPageExpired(nsIURI
uint16_t aReason, uint32_t aTransitionType)
{
// Invalidate the cached value for whether there's history or not.
mDaysOfHistory = -1;
MOZ_ASSERT(!aGUID.IsEmpty());
if (aWholeEntry) {
// Notify our observers that the page has been removed.
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavHistoryObserver, OnDeleteURI(aURI, aGUID, aReason));
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavHistoryObserver,
+ OnDeleteURI(aURI, aGUID, aReason));
}
else {
// Notify our observers that some visits for the page have been removed.
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavHistoryObserver,
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavHistoryObserver,
OnDeleteVisits(aURI, aVisitTime, aGUID, aReason,
aTransitionType));
}
return NS_OK;
}
////////////////////////////////////////////////////////////////////////////////
@@ -4166,18 +4154,17 @@ nsNavHistory::URIToResultNode(nsIURI* aU
void
nsNavHistory::SendPageChangedNotification(nsIURI* aURI,
uint32_t aChangedAttribute,
const nsAString& aNewValue,
const nsACString& aGUID)
{
MOZ_ASSERT(!aGUID.IsEmpty());
- NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
- nsINavHistoryObserver,
+ NOTIFY_OBSERVERS(mCanNotify, mObservers, nsINavHistoryObserver,
OnPageChanged(aURI, aChangedAttribute, aNewValue, aGUID));
}
// nsNavHistory::TitleForDomain
//
// This computes the title for a given domain. Normally, this is just the
// domain name, but we specially handle empty cases to give you a nice
// localized string.