--- a/browser/base/content/tabbrowser.xml
+++ b/browser/base/content/tabbrowser.xml
@@ -494,22 +494,22 @@
}
}
}
}
if (!aBrowser)
aBrowser = this.mCurrentBrowser;
- if (aCallGlobalListeners != false &&
+ if (aCallGlobalListeners &&
aBrowser == this.mCurrentBrowser) {
callListeners(this.mProgressListeners, aArguments);
}
- if (aCallTabsListeners != false) {
+ if (aCallTabsListeners) {
aArguments.unshift(aBrowser);
callListeners(this.mTabsProgressListeners, aArguments);
}
return rv;
]]></body>
</method>
--- a/browser/components/enterprisepolicies/Policies.jsm
+++ b/browser/components/enterprisepolicies/Policies.jsm
@@ -34,17 +34,17 @@ this.Policies = {
if (param) {
manager.disallowFeature("about:config", true);
}
}
},
"DisableAppUpdate": {
onBeforeAddons(manager, param) {
- if (param == true) {
+ if (param) {
manager.disallowFeature("appUpdate");
}
}
},
"display_menu_bar": {
onBeforeUIStartup(manager, param) {
if (param) {
@@ -92,25 +92,25 @@ this.Policies = {
if (param) {
setAndLockPref("extensions.screenshots.disabled", true);
}
}
},
"DisableFirefoxStudies": {
onBeforeAddons(manager, param) {
- if (param == true) {
+ if (param) {
manager.disallowFeature("Shield");
}
}
},
"DisableFormHistory": {
onBeforeUIStartup(manager, param) {
- if (param == true) {
+ if (param) {
setAndLockPref("browser.formfill.enable", false);
}
}
},
"dont_check_default_browser": {
onBeforeUIStartup(manager, param) {
setAndLockPref("browser.shell.checkDefaultBrowser", false);
--- a/mobile/android/components/BlocklistPrompt.js
+++ b/mobile/android/components/BlocklistPrompt.js
@@ -21,17 +21,17 @@ BlocklistPrompt.prototype = {
let bundle = Services.strings.createBundle("chrome://browser/locale/browser.properties");
let notifyBox = win.getNotificationBox();
let restartCallback = function(aNotification, aDescription) {
// Notify all windows that an application quit has been requested
var cancelQuit = Cc["@mozilla.org/supports-PRBool;1"].createInstance(Ci.nsISupportsPRBool);
Services.obs.notifyObservers(cancelQuit, "quit-application-requested", "restart");
// If nothing aborted, quit the app
- if (cancelQuit.data == false) {
+ if (!cancelQuit.data) {
let appStartup = Cc["@mozilla.org/toolkit/app-startup;1"].getService(Ci.nsIAppStartup);
appStartup.quit(Ci.nsIAppStartup.eRestart | Ci.nsIAppStartup.eAttemptQuit);
}
};
let buttons = [{accessKey: null,
label: bundle.GetStringFromName("notificationRestart.button"),
callback: restartCallback}];
--- a/mobile/android/components/NSSDialogService.js
+++ b/mobile/android/components/NSSDialogService.js
@@ -253,17 +253,17 @@ NSSDialogs.prototype = {
checked: rememberSetting
});
let response = this.showPrompt(prompt);
selectedIndex.value = response.nicknames;
if (response.button == 1 /* buttons[1] */) {
this.viewCertDetails(certDetailsList[selectedIndex.value], ctx);
continue;
} else if (response.button == 0 /* buttons[0] */) {
- if (response.rememberBox == true) {
+ if (response.rememberBox) {
let caud = ctx.QueryInterface(Ci.nsIClientAuthUserDecision);
if (caud) {
caud.rememberClientAuthCertificate = true;
}
}
return true;
}
return false;
--- a/mobile/android/tests/browser/robocop/testVideoControls.js
+++ b/mobile/android/tests/browser/robocop/testVideoControls.js
@@ -84,17 +84,17 @@ function testLoad() {
// Let's start playing it
video.play();
video.addEventListener("play", testPlay);
}
function testPlay(aEvent) {
video.removeEventListener("play", testPlay);
let playButton = getButtonByAttribute("class", "playButton");
- ok(playButton.hasAttribute("paused") == false, "Play button is not paused");
+ ok(!playButton.hasAttribute("paused"), "Play button is not paused");
// Let the video play for 2 seconds, then pause it
chromeWin.setTimeout(function() {
video.pause();
video.addEventListener("pause", testPause);
}, 2000);
}
--- a/security/sandbox/test/browser_content_sandbox_fs.js
+++ b/security/sandbox/test/browser_content_sandbox_fs.js
@@ -213,50 +213,50 @@ add_task(async function() {
});
// Test if the content process can create in $HOME, this should fail
async function createFileInHome() {
let browser = gBrowser.selectedBrowser;
let homeFile = fileInHomeDir();
let path = homeFile.path;
let fileCreated = await ContentTask.spawn(browser, path, createFile);
- ok(fileCreated == false, "creating a file in home dir is not permitted");
- if (fileCreated == true) {
+ ok(!fileCreated, "creating a file in home dir is not permitted");
+ if (fileCreated) {
// content process successfully created the file, now remove it
homeFile.remove(false);
}
}
// Test if the content process can create a temp file, this is disallowed on
// macOS but allowed everywhere else. Also test that the content process cannot
// create symlinks or delete files.
async function createTempFile() {
let browser = gBrowser.selectedBrowser;
let path = fileInTempDir().path;
let fileCreated = await ContentTask.spawn(browser, path, createFile);
if (isMac()) {
- ok(fileCreated == false, "creating a file in content temp is not permitted");
+ ok(!fileCreated, "creating a file in content temp is not permitted");
} else {
- ok(fileCreated == true, "creating a file in content temp is permitted");
+ ok(!!fileCreated, "creating a file in content temp is permitted");
}
// now delete the file
let fileDeleted = await ContentTask.spawn(browser, path, deleteFile);
if (isMac()) {
// On macOS we do not allow file deletion - it is not needed by the content
// process itself, and macOS uses a different permission to control access
// so revoking it is easy.
- ok(fileDeleted == false,
+ ok(!fileDeleted,
"deleting a file in content temp is not permitted");
let path = fileInTempDir().path;
let symlinkCreated = await ContentTask.spawn(browser, path, createSymlink);
- ok(symlinkCreated == false,
+ ok(!symlinkCreated,
"created a symlink in content temp is not permitted");
} else {
- ok(fileDeleted == true, "deleting a file in content temp is permitted");
+ ok(!!fileDeleted, "deleting a file in content temp is permitted");
}
}
// Test reading files and dirs from web and file content processes.
async function testFileAccess() {
// for tests that run in a web content process
let webBrowser = gBrowser.selectedBrowser;
--- a/services/common/blocklist-clients.js
+++ b/services/common/blocklist-clients.js
@@ -58,17 +58,17 @@ function mergeChanges(collection, localR
const records = {};
// Local records by id.
localRecords.forEach((record) => records[record.id] = collection.cleanLocalFields(record));
// All existing records are replaced by the version from the server.
changes.forEach((record) => records[record.id] = record);
return Object.values(records)
// Filter out deleted records.
- .filter((record) => record.deleted != true)
+ .filter((record) => !record.deleted)
// Sort list by record id.
.sort((a, b) => {
if (a.id < b.id) {
return -1;
}
return a.id > b.id ? 1 : 0;
});
}
--- a/storage/test/unit/test_statement_executeAsync.js
+++ b/storage/test/unit/test_statement_executeAsync.js
@@ -90,29 +90,29 @@ function execAsync(aStmt, aOptions, aRes
resultsSeen++;
resultsSeenThisCall++;
}
if (!resultsSeenThisCall)
do_throw("handleResult invoked with 0 result rows!");
},
handleError(aError) {
- if (errorCodeSeen != false)
+ if (errorCodeSeen)
do_throw("handleError called when we already had an error!");
errorCodeSeen = aError.result;
},
handleCompletion(aReason) {
if (completed) // paranoia check
do_throw("Received a second handleCompletion notification!", caller);
if (resultsSeen != resultsExpected)
do_throw("Expected " + resultsExpected + " rows of results but " +
"got " + resultsSeen + " rows!", caller);
- if (errorCodeExpected == true && errorCodeSeen == false)
+ if (errorCodeExpected && !errorCodeSeen)
do_throw("Expected an error, but did not see one.", caller);
else if (errorCodeExpected != errorCodeSeen)
do_throw("Expected error code " + errorCodeExpected + " but got " +
errorCodeSeen, caller);
if (aReason != reasonExpected && aReason != altReasonExpected)
do_throw("Expected reason " + reasonExpected +
(altReasonExpected ? (" or " + altReasonExpected) : "") +
--- a/testing/marionette/listener.js
+++ b/testing/marionette/listener.js
@@ -1394,17 +1394,17 @@ function switchToFrame(msg) {
}
if ((msg.json.id === null || msg.json.id === undefined) &&
(msg.json.element == null)) {
// returning to root frame
sendSyncMessage("Marionette:switchedToFrame", {frameValue: null});
curContainer.frame = content;
- if (msg.json.focus == true) {
+ if (msg.json.focus) {
curContainer.frame.focus();
}
sendOk(commandID);
return;
}
let webEl;
@@ -1459,17 +1459,17 @@ function switchToFrame(msg) {
curContainer.frame = foundFrame;
foundFrame = seenEls.add(curContainer.frame);
} else {
// If foundFrame is null at this point then we have the top
// level browsing context so should treat it accordingly.
sendSyncMessage("Marionette:switchedToFrame", {frameValue: null});
curContainer.frame = content;
- if (msg.json.focus == true) {
+ if (msg.json.focus) {
curContainer.frame.focus();
}
sendOk(commandID);
return;
}
} catch (e) {
// Since window.frames does not return OOP frames it will throw
--- a/testing/specialpowers/content/specialpowersAPI.js
+++ b/testing/specialpowers/content/specialpowersAPI.js
@@ -814,17 +814,17 @@ SpecialPowersAPI.prototype = {
let perm;
if (typeof permission.allow !== "boolean") {
perm = permission.allow;
} else {
perm = permission.allow ? Ci.nsIPermissionManager.ALLOW_ACTION
: Ci.nsIPermissionManager.DENY_ACTION;
}
- if (permission.remove == true)
+ if (permission.remove)
perm = Ci.nsIPermissionManager.UNKNOWN_ACTION;
if (originalValue == perm) {
continue;
}
var todo = {"op": "add",
"type": permission.type,
@@ -833,17 +833,17 @@ SpecialPowersAPI.prototype = {
"principal": principal,
"expireType": (typeof permission.expireType === "number") ?
permission.expireType : 0, // default: EXPIRE_NEVER
"expireTime": (typeof permission.expireTime === "number") ?
permission.expireTime : 0};
var cleanupTodo = Object.assign({}, todo);
- if (permission.remove == true)
+ if (permission.remove)
todo.op = "remove";
pendingPermissions.push(todo);
/* Push original permissions value or clear into cleanup array */
if (originalValue == Ci.nsIPermissionManager.UNKNOWN_ACTION) {
cleanupTodo.op = "remove";
} else {
--- a/testing/talos/talos/pageloader/chrome/pageloader.js
+++ b/testing/talos/talos/pageloader/chrome/pageloader.js
@@ -401,17 +401,17 @@ var plNextPage = async function() {
doNextPage = true;
} else if (pageIndex < pages.length - 1) {
pageIndex++;
recordedName = null;
pageCycle = 1;
doNextPage = true;
}
- if (doNextPage == true) {
+ if (doNextPage) {
if (forceCC) {
var tccstart = new Date();
window.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
.getInterface(Components.interfaces.nsIDOMWindowUtils)
.garbageCollect();
var tccend = new Date();
report.recordCCTime(tccend - tccstart);
@@ -535,17 +535,17 @@ function sendScroll() {
function plWaitForPaintingCapturing() {
if (gPaintListener)
return;
var utils = gPaintWindow.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
.getInterface(Components.interfaces.nsIDOMWindowUtils);
if (utils.isMozAfterPaintPending && useMozAfterPaint) {
- if (gPaintListener == false)
+ if (!gPaintListener)
gPaintWindow.addEventListener("MozAfterPaint", plPaintedCapturing, true);
gPaintListener = true;
return;
}
_loadHandlerCapturing();
}
@@ -596,17 +596,17 @@ function waitForPainted() {
var utils = gPaintWindow.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
.getInterface(Components.interfaces.nsIDOMWindowUtils);
if (!utils.isMozAfterPaintPending || !useMozAfterPaint) {
_loadHandler();
return;
}
- if (gPaintListener == false)
+ if (!gPaintListener)
gPaintWindow.addEventListener("MozAfterPaint", plPainted, true);
gPaintListener = true;
}
function plPainted() {
gPaintWindow.removeEventListener("MozAfterPaint", plPainted, true);
gPaintListener = false;
_loadHandler();
@@ -698,17 +698,17 @@ function plErrorMessage(message) {
function plStop(force) {
plStopAll(force);
}
function plStopAll(force) {
try {
- if (force == false) {
+ if (!force) {
pageIndex = 0;
pageCycle = 1;
if (cycle < NUM_CYCLES - 1) {
cycle++;
recordedName = null;
setTimeout(plLoadPage, delay);
return;
}
--- a/toolkit/components/osfile/tests/xpcshell/test_constants.js
+++ b/toolkit/components/osfile/tests/xpcshell/test_constants.js
@@ -9,14 +9,14 @@ add_task(async function check_definition
Assert.ok(OS.Constants != null);
Assert.ok(!!OS.Constants.Win || !!OS.Constants.libc);
Assert.ok(OS.Constants.Path != null);
Assert.ok(OS.Constants.Sys != null);
// check system name
Assert.equal(Services.appinfo.OS, OS.Constants.Sys.Name);
// check if using DEBUG build
- if (Components.classes["@mozilla.org/xpcom/debug;1"].getService(Components.interfaces.nsIDebug2).isDebugBuild == true) {
+ if (Components.classes["@mozilla.org/xpcom/debug;1"].getService(Components.interfaces.nsIDebug2).isDebugBuild) {
Assert.ok(OS.Constants.Sys.DEBUG);
} else {
Assert.ok(typeof(OS.Constants.Sys.DEBUG) == "undefined");
}
});
--- a/toolkit/components/passwordmgr/test/browser/browser_formless_submit_chrome.js
+++ b/toolkit/components/passwordmgr/test/browser/browser_formless_submit_chrome.js
@@ -83,17 +83,17 @@ add_task(async function test_backButton_
await fillTestPage(aBrowser);
if (forwardTransitionPromise) {
await forwardTransitionPromise;
info("transition done");
}
await BrowserTestUtils.waitForCondition(() => {
- return forwardButton.disabled == false;
+ return !forwardButton.disabled;
});
let forwardPromise = BrowserTestUtils.browserStopped(aBrowser);
info("click the forward button");
EventUtils.synthesizeMouseAtCenter(forwardButton, {});
await forwardPromise;
});
});
@@ -101,17 +101,17 @@ add_task(async function test_backButton_
add_task(async function test_reloadButton() {
await withTestPage(async function(aBrowser) {
let reloadButton = document.getElementById("reload-button");
let loadPromise = BrowserTestUtils.browserLoaded(aBrowser, false,
"https://example.com" + DIRECTORY_PATH +
"formless_basic.html");
await BrowserTestUtils.waitForCondition(() => {
- return reloadButton.disabled == false;
+ return !reloadButton.disabled;
});
EventUtils.synthesizeMouseAtCenter(reloadButton, {});
await loadPromise;
});
});
add_task(async function test_back_keyboard_shortcut() {
if (Services.prefs.getIntPref("browser.backspace_action") != 0) {
--- a/toolkit/components/places/tests/unit/test_null_interfaces.js
+++ b/toolkit/components/places/tests/unit/test_null_interfaces.js
@@ -57,17 +57,17 @@ function run_test() {
info(`\nTesting ${ifaces.join(", ")} function with null args: ${n}`);
let func = s[n];
let num = func.length;
info(`Generating array of nulls for #args: ${num}`);
let args = Array(num).fill(null);
let tryAgain = true;
- while (tryAgain == true) {
+ while (tryAgain) {
try {
info(`Calling with args: ${JSON.stringify(args)}`);
func.apply(s, args);
info(`The function did not throw! Is it one of the nothrow? ${nothrow}`);
Assert.notEqual(nothrow.indexOf(n), -1);
info("Must have been an expected nothrow, so no need to try again");
--- a/toolkit/components/telemetry/tests/unit/test_TelemetryEvents.js
+++ b/toolkit/components/telemetry/tests/unit/test_TelemetryEvents.js
@@ -147,17 +147,17 @@ add_task(async function test_recording()
// Check that the expected events were recorded.
let snapshot = Telemetry.snapshotEvents(OPTIN, false);
Assert.ok(("parent" in snapshot), "Should have entry for main process.");
checkEvents(snapshot.parent, expected);
// Check serializing only opt-out events.
snapshot = Telemetry.snapshotEvents(OPTOUT, false);
Assert.ok(("parent" in snapshot), "Should have entry for main process.");
- let filtered = expected.filter(e => e.optout == true);
+ let filtered = expected.filter(e => !!e.optout);
checkEvents(snapshot.parent, filtered);
});
add_task(async function test_clear() {
Telemetry.clearEvents();
const COUNT = 10;
for (let i = 0; i < COUNT; ++i) {
--- a/toolkit/content/preferencesBindings.js
+++ b/toolkit/content/preferencesBindings.js
@@ -221,17 +221,17 @@ const Preferences = window.Preferences =
// Panel loaded, synthesize a load event.
try {
const event = document.createEvent("Events");
event.initEvent(aEventName, true, true);
let cancel = !aTarget.dispatchEvent(event);
if (aTarget.hasAttribute("on" + aEventName)) {
const fn = new Function("event", aTarget.getAttribute("on" + aEventName));
const rv = fn.call(aTarget, event);
- if (rv == false)
+ if (!rv)
cancel = true;
}
return !cancel;
} catch (e) {
Cu.reportError(e);
}
return false;
},
--- a/toolkit/content/tests/browser/browser_bug295977_autoscroll_overflow.js
+++ b/toolkit/content/tests/browser/browser_bug295977_autoscroll_overflow.js
@@ -92,17 +92,17 @@ body > div > div {width: 1000px;height:
for (let test of allTests) {
if (test.dataUri) {
let loadedPromise = BrowserTestUtils.browserLoaded(gBrowser.selectedBrowser);
gBrowser.loadURI(test.dataUri);
await loadedPromise;
continue;
}
- let prefsChanged = (test.middlemousepastepref == false || test.middlemousepastepref == true);
+ let prefsChanged = "middlemousepastepref" in test;
if (prefsChanged) {
await pushPrefs([["middlemouse.paste", test.middlemousepastepref]]);
}
await BrowserTestUtils.synthesizeMouse("#" + test.elem, 50, 80, { button: 1 },
gBrowser.selectedBrowser);
// This ensures bug 605127 is fixed: pagehide in an unrelated document
--- a/toolkit/content/widgets/colorpicker.xml
+++ b/toolkit/content/widgets/colorpicker.xml
@@ -226,17 +226,17 @@
<![CDATA[
try {
var event = document.createEvent("Events");
event.initEvent(aEventName, true, true);
var cancel = !aTarget.dispatchEvent(event);
if (aTarget.hasAttribute("on" + aEventName)) {
var fn = new Function("event", aTarget.getAttribute("on" + aEventName));
var rv = fn.call(aTarget, event);
- if (rv == false)
+ if (!rv)
cancel = true;
}
return !cancel;
} catch (e) {
Components.utils.reportError(e);
}
return false;
]]>
@@ -481,17 +481,17 @@
<![CDATA[
try {
var event = document.createEvent("Events");
event.initEvent(aEventName, true, true);
var cancel = !aTarget.dispatchEvent(event);
if (aTarget.hasAttribute("on" + aEventName)) {
var fn = new Function("event", aTarget.getAttribute("on" + aEventName));
var rv = fn.call(aTarget, event);
- if (rv == false)
+ if (!rv)
cancel = true;
}
return !cancel;
} catch (e) {
dump(e);
}
return false;
]]>
--- a/toolkit/content/widgets/dialog.xml
+++ b/toolkit/content/widgets/dialog.xml
@@ -415,17 +415,17 @@
// handle dom event handlers
var noCancel = this.dispatchEvent(event);
// handle any xml attribute event handlers
var handler = this.getAttribute("ondialog" + aDlgType);
if (handler != "") {
var fn = new Function("event", handler);
var returned = fn(event);
- if (returned == false)
+ if (!returned)
noCancel = false;
}
return noCancel;
]]>
</body>
</method>
--- a/toolkit/mozapps/extensions/content/extensions.js
+++ b/toolkit/mozapps/extensions/content/extensions.js
@@ -2111,17 +2111,17 @@ var gDiscoverView = {
this._browser.addProgressListener(this);
if (this.loaded)
this._loadURL(this.homepageURL.spec, false, notifyInitialized);
else
notifyInitialized();
};
- if (Services.prefs.getBoolPref(PREF_GETADDONS_CACHE_ENABLED) == false) {
+ if (!Services.prefs.getBoolPref(PREF_GETADDONS_CACHE_ENABLED)) {
setURL(url);
return;
}
gPendingInitializations++;
AddonManager.getAllAddons(function(aAddons) {
var list = {};
for (let addon of aAddons) {
--- a/toolkit/mozapps/extensions/test/browser/browser_webapi.js
+++ b/toolkit/mozapps/extensions/test/browser/browser_webapi.js
@@ -109,16 +109,16 @@ add_task(testWithAPI(async function(brow
async function check(value, message) {
let enabled = await ContentTask.spawn(browser, null, async function() {
return content.navigator.mozAddonManager.permissionPromptsEnabled;
});
is(enabled, value, message);
}
const PERM = "extensions.webextPermissionPrompts";
- if (Services.prefs.getBoolPref(PERM, false) == false) {
+ if (!Services.prefs.getBoolPref(PERM, false)) {
await SpecialPowers.pushPrefEnv({clear: [[PERM]]});
await check(false, `mozAddonManager.permissionPromptsEnabled is false when ${PERM} is unset`);
}
await SpecialPowers.pushPrefEnv({set: [[PERM, true]]});
await check(true, `mozAddonManager.permissionPromptsEnabled is true when ${PERM} is set`);
}));
--- a/toolkit/mozapps/extensions/test/xpcshell/test_filepointer.js
+++ b/toolkit/mozapps/extensions/test/xpcshell/test_filepointer.js
@@ -79,17 +79,17 @@ function writeRelativePointer(aId, aName
FileUtils.MODE_WRONLY | FileUtils.MODE_CREATE | FileUtils.MODE_TRUNCATE,
FileUtils.PERMS_FILE, 0);
fos.write(relTarget, relTarget.length);
fos.close();
}
function run_test() {
// pointer files only work with unpacked directories
- if (Services.prefs.getBoolPref("extensions.alwaysUnpack") == false)
+ if (!Services.prefs.getBoolPref("extensions.alwaysUnpack"))
return;
do_test_pending();
createAppInfo("xpcshell@tests.mozilla.org", "XPCShell", "1", "1");
// Create and configure the HTTP server.
testserver = new HttpServer();
testserver.registerDirectory("/data/", do_get_file("data"));