Bug 1433305 - Remove a no more useful Places crash test. r=standard8 draft
authorMarco Bonardo <mbonardo@mozilla.com>
Wed, 07 Feb 2018 18:14:53 +0100
changeset 752454 8af9e2af669a076e83844c309245b43a2a71e983
parent 752051 ea00596eb02e86a919c6734a2307ff118a01d257
child 752455 72dfd1aaf81884213744a2ff82eb453f5daefb71
child 752456 c673e78f9656aeecc065867c441b9aaf116c5f06
push id98274
push usermak77@bonardo.net
push dateThu, 08 Feb 2018 09:25:46 +0000
reviewersstandard8
bugs1433305
milestone60.0a1
Bug 1433305 - Remove a no more useful Places crash test. r=standard8 MozReview-Commit-ID: EVLZXi242xA
toolkit/components/places/tests/unit/bug476292.sqlite
toolkit/components/places/tests/unit/test_crash_476292.js
toolkit/components/places/tests/unit/xpcshell.ini
deleted file mode 100644
index 43130cb51efc0392c0b26ffca5e43debd218d9cb..0000000000000000000000000000000000000000
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100644
--- a/toolkit/components/places/tests/unit/test_crash_476292.js
+++ /dev/null
@@ -1,25 +0,0 @@
-/* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
-/* vim:set ts=2 sw=2 sts=2 et: */
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-/**
- * This tests a crash during startup found in bug 476292 that was caused by
- * getting the bookmarks service during nsNavHistory::Init when the bookmarks
- * service was created before the history service was.
- */
-
-function run_test() {
-  // First, we need to move our old database file into our test profile
-  // directory.  This will trigger DATABASE_STATUS_UPGRADED (CREATE is not
-  // sufficient since there will be no entries to update frecencies for, which
-  // causes us to get the bookmarks service in the first place).
-  let dbFile = do_get_file("bug476292.sqlite");
-  let profD = Services.dirsvc.get(NS_APP_USER_PROFILE_50_DIR, Ci.nsIFile);
-  dbFile.copyTo(profD, "places.sqlite");
-
-  // Now get the bookmarks service.  This will crash when the bug exists.
-  Cc["@mozilla.org/browser/nav-bookmarks-service;1"].
-    getService(Ci.nsINavBookmarksService);
-}
--- a/toolkit/components/places/tests/unit/xpcshell.ini
+++ b/toolkit/components/places/tests/unit/xpcshell.ini
@@ -2,17 +2,16 @@
 head = head_bookmarks.js
 firefox-appdir = browser
 support-files =
   bookmarks.corrupt.html
   bookmarks.json
   bookmarks_corrupt.json
   bookmarks.preplaces.html
   bookmarks_html_singleframe.html
-  bug476292.sqlite
   corruptDB.sqlite
   livemark.xml
   mobile_bookmarks_folder_import.json
   mobile_bookmarks_folder_merge.json
   mobile_bookmarks_multiple_folders.json
   mobile_bookmarks_root_import.json
   mobile_bookmarks_root_merge.json
   nsDummyObserver.js
@@ -72,17 +71,16 @@ skip-if = (os == 'win' && ccov) # Bug 14
 [test_bookmarks_html_import_tags.js]
 [test_bookmarks_html_singleframe.js]
 [test_bookmarks_restore_notification.js]
 [test_broken_folderShortcut_result.js]
 [test_browserhistory.js]
 [test_bug636917_isLivemark.js]
 [test_childlessTags.js]
 [test_corrupt_telemetry.js]
-[test_crash_476292.js]
 [test_database_replaceOnStartup.js]
 [test_download_history.js]
 [test_frecency.js]
 [test_frecency_decay.js]
 [test_frecency_zero_updated.js]
 [test_getChildIndex.js]
 [test_hash.js]
 [test_history.js]