Bug 1436380 - Fix async issues in TabBar.js r+nchevobbe draft
authorMichael Ratcliffe <mratcliffe@mozilla.com>
Wed, 07 Feb 2018 16:10:07 +0000
changeset 752135 f21eb1aca049a4a443a52314aa4cae5bc6c00517
parent 752051 ea00596eb02e86a919c6734a2307ff118a01d257
child 752160 32513c40cecd76f3784203daa8729ed1df25414e
push id98174
push userbmo:mratcliffe@mozilla.com
push dateWed, 07 Feb 2018 16:11:39 +0000
bugs1436380
milestone60.0a1
Bug 1436380 - Fix async issues in TabBar.js r+nchevobbe MozReview-Commit-ID: 2dGIQLQPRV9
devtools/client/shared/components/tabs/TabBar.js
--- a/devtools/client/shared/components/tabs/TabBar.js
+++ b/devtools/client/shared/components/tabs/TabBar.js
@@ -194,21 +194,21 @@ class Tabbar extends Component {
     return this.state.tabs[this.state.activeTab].id;
   }
 
   // Event Handlers
 
   onTabChanged(index) {
     this.setState({
       activeTab: index
+    }, () => {
+      if (this.props.onSelect) {
+        this.props.onSelect(this.state.tabs[index].id);
+      }
     });
-
-    if (this.props.onSelect) {
-      this.props.onSelect(this.state.tabs[index].id);
-    }
   }
 
   onAllTabsMenuClick(event) {
     let menu = new Menu();
     let target = event.target;
 
     // Generate list of menu items from the list of tabs.
     this.state.tabs.forEach((tab) => {